fix(deletions): Retry fetching rows after timeouts when doing bulk deletes #102369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
evanpurkhiser
approved these changes
Oct 29, 2025
wedamija
force-pushed
the
danf/retry-deletes-take-2
branch
from
b02b8ac to
4ef641a
Compare
wedamija
force-pushed
the
danf/retry-deletes-take-2
branch
from
4ef641a to
0f7303a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…letes We're seeing periodic timeouts when deleting commits, but they also succeed most of the time. Adding in some retries to work around this. Trying this again since we saw flakes on master
wedamija
force-pushed
the
danf/retry-deletes-take-2
branch
from
d705286 to
99d6b01
Compare
scttcper
approved these changes
Oct 30, 2025
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
…letes (#102369) We're seeing periodic timeouts when deleting commits, but they also succeed most of the time. Adding in some retries to work around this. Trying this again since we saw flakes on master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing periodic timeouts when deleting commits, but they also succeed most of the time. Adding in some retries to work around this.
Trying this again since we saw flakes on master