chore: Updated Samples #2256
Merged
chore: Updated Samples #2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samples/unity-of-bugs/Assets/Scripts/AdditionalSamplesButtons.cs
Outdated
Show resolved
Hide resolved
bitsandfoxes
commented
Aug 4, 2025
There was a problem hiding this comment.
There is some duplicating of code here from BugFarmButtons. I'm doing this so we can keep everything that happens here in one file. The whole _executor logic already adds mental overload to the samples so the actual error is right in from of user's eyes.
bitsandfoxes
commented
Aug 4, 2025
| @@ -3,7 +3,6 @@ | |||
| "com.unity.collab-proxy": "2.0.7", | |||
| "com.unity.ide.rider": "3.0.36", | |||
| "com.unity.ide.visualstudio": "2.0.23", | |||
| "com.unity.ide.vscode": "1.2.5", | |||
There was a problem hiding this comment.
We're not using it - and it's deprecated in future Unity versions anyway.
bitsandfoxes
commented
Aug 4, 2025
| AndroidBundleVersionCode: 1 | ||
| AndroidMinSdkVersion: 19 | ||
| AndroidMinSdkVersion: 21 |
There was a problem hiding this comment.
New min SDK version with Unity 2020
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bruno-garcia
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the samples, this includes but is not limited to
ForceCrashin dedicated scene#skip-changelog