Skip to content

ci: adopt Danger with Sentry's shared config #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

ci: adopt Danger with Sentry's shared config #815

merged 3 commits into from
May 23, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented May 23, 2025

Enables Danger with our shared config.
I prefer to be forced to write the changelog directly with each PR.

@lcian lcian changed the title ci: adopt Danger with Sentry's shared config whatever: adopt Danger with Sentry's shared config May 23, 2025
@lcian lcian changed the title whatever: adopt Danger with Sentry's shared config ci: adopt Danger with Sentry's shared config May 23, 2025
@lcian
Copy link
Member Author

lcian commented May 23, 2025

Okay it works, it looked like it wasn't working because a commit with ci scope doesn't require a changelog entry

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, if you must, why not :-D

I personally hate this, but I think it makes sense to actually enforce for a SDK repo (as opposed to symbolic/ator which had this set up, just to be a huge pain in the rear.

@lcian
Copy link
Member Author

lcian commented May 23, 2025

Yeah, no one is forcing me to enable it but personally I find it easier to do the changelog immediately rather than having to describe what I did later and requiring an additional PR.

@lcian lcian merged commit 622d49a into master May 23, 2025
19 of 20 checks passed
@lcian lcian deleted the lcian/ci/danger branch May 23, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants