Skip to content

Don't gate request query strings and form data behind send_default_pii - #2452

Closed
sl0thentr0py wants to merge 5 commits into
masterfrom
neel/fix-rails-pii-params
Closed

sl0thentr0py wants to merge 5 commits into
masterfrom
neel/fix-rails-pii-params

Don't gate request query strings and form data behind send_default_pii

c6d6137
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 23, 2025 in 1s

98.06% (-0.10%) compared to 9446a30

View this Pull Request on Codecov

98.06% (-0.10%) compared to 9446a30

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.06%. Comparing base (9446a30) to head (c6d6137).
⚠️ Report is 183 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
- Coverage   98.16%   98.06%   -0.10%     
==========================================
  Files         126      126              
  Lines        4741     4708      -33     
==========================================
- Hits         4654     4617      -37     
- Misses         87       91       +4     
Components Coverage Δ
sentry-ruby 98.47% <100.00%> (-0.05%) ⬇️
sentry-rails 96.72% <100.00%> (-0.33%) ⬇️
sentry-sidekiq 97.63% <ø> (ø)
sentry-resque 91.42% <ø> (-1.43%) ⬇️
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/background_worker.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 96.96% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb_buffer.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/check_in_event.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 98.86% <ø> (-0.03%) ⬇️
sentry-ruby/lib/sentry/cron/monitor_config.rb 95.45% <100.00%> (ø)
sentry-ruby/lib/sentry/cron/monitor_schedule.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/error_event.rb 100.00% <100.00%> (ø)
... and 20 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.