fix(redis): Use command_queue instead of command_stack if available#4404
Merged
sentrivana merged 5 commits intomasterfrom May 20, 2025
Merged
fix(redis): Use command_queue instead of command_stack if available#4404sentrivana merged 5 commits intomasterfrom
command_queue instead of command_stack if available#4404sentrivana merged 5 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
| Files with missing lines | Coverage Δ | |
|---|---|---|
| sentry_sdk/integrations/redis/_sync_common.py | 86.79% <100.00%> (+1.37%) |
⬆️ |
| sentry_sdk/integrations/redis/utils.py | 92.20% <100.00%> (ø) |
szokeasaurusrex
previously approved these changes
May 20, 2025
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Contributor
Author
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit in
redis-pymoved away from using the Pipeline'scommand_stackand is now using_execution_strategy.command_queueinstead. We need to adapt to use the new command source if present.This fixes
redis-latestin CI.