-
Notifications
You must be signed in to change notification settings - Fork 547
fix(redis): Use command_queue
instead of command_stack
if available
#4404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Files with missing lines | Coverage Δ | |
---|---|---|
sentry_sdk/integrations/redis/_sync_common.py | 86.79% <100.00%> (+1.37%) |
⬆️ |
sentry_sdk/integrations/redis/utils.py | 92.20% <100.00%> (ø) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need any tests for this, or will it just get "automatically" tested by the latest redis tests?
Co-authored-by: Daniel Szoke <[email protected]>
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This commit in
redis-py
moved away from using the Pipeline'scommand_stack
and is now using_execution_strategy.command_queue
instead. We need to adapt to use the new command source if present.This fixes
redis-latest
in CI.