Skip to content

Increase test coverage #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 20, 2025
Merged

Increase test coverage #4393

merged 14 commits into from
May 20, 2025

Conversation

mgaligniana
Copy link
Contributor

@mgaligniana mgaligniana commented May 15, 2025

Fixes GH-3515

Summary:

Before
image
image

After
image
image

@mgaligniana mgaligniana changed the title test(utils): Add test for datetime_from_isoformat Increase test coverage May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.61%. Comparing base (e2e8f92) to head (4f7bfec).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4393      +/-   ##
==========================================
+ Coverage   80.28%   80.61%   +0.32%     
==========================================
  Files         142      142              
  Lines       15961    15961              
  Branches     2726     2726              
==========================================
+ Hits        12815    12867      +52     
+ Misses       2271     2238      -33     
+ Partials      875      856      -19     

see 4 files with indirect coverage changes

@mgaligniana mgaligniana marked this pull request as ready for review May 19, 2025 04:15
@mgaligniana mgaligniana requested a review from a team as a code owner May 19, 2025 04:15
Copy link
Contributor Author

@mgaligniana mgaligniana May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎗️ For some reason when I run it alone the coverage is 100%. When I run the whole test suite I get 95%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 👣 Found it. Couple of tests fail running the entire suite

image

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks @mgaligniana for improving our test coverage! 💯

@antonpirker antonpirker enabled auto-merge (squash) May 20, 2025 07:18
@antonpirker antonpirker merged commit 94414cd into getsentry:master May 20, 2025
141 of 145 checks passed
@mgaligniana
Copy link
Contributor Author

Thanks @antonpirker !

Anton, if it's not too much trouble, could you give me a way to contact you? For a few small Sentry questions!

@antonpirker
Copy link
Member

sure: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase test coverage
2 participants