-
Notifications
You must be signed in to change notification settings - Fork 550
Increase test coverage #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase test coverage #4393
Conversation
datetime_from_isoformat
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4393 +/- ##
==========================================
+ Coverage 80.28% 80.61% +0.32%
==========================================
Files 142 142
Lines 15961 15961
Branches 2726 2726
==========================================
+ Hits 12815 12867 +52
+ Misses 2271 2238 -33
+ Partials 875 856 -19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎗️ For some reason when I run it alone the coverage is 100%. When I run the whole test suite I get 95%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks @mgaligniana for improving our test coverage! 💯
Thanks @antonpirker ! Anton, if it's not too much trouble, could you give me a way to contact you? For a few small Sentry questions! |
sure: [email protected] |
Fixes GH-3515
Summary:
Before


After

