Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to set debug log level #1107

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Dec 18, 2024

Fixes #888
Related to getsentry/sentry-cocoa#4467

The main goal is to allow for outputting just the warnings from sentry_init. To accommodate this, we introduce log levels as a way to control what level of output the user gets. We decided against splitting up these levels into init-only and global levels, since this doesn't seem like a necessary feature as of yet.

Copy link

github-actions bot commented Dec 18, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ad4359e

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 61.29032% with 36 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (19ba6d5) to head (ad4359e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
- Coverage   82.57%   82.49%   -0.08%     
==========================================
  Files          53       53              
  Lines        7889     7896       +7     
  Branches     1232     1234       +2     
==========================================
  Hits         6514     6514              
- Misses       1263     1270       +7     
  Partials      112      112              

src/sentry_options.c Outdated Show resolved Hide resolved
src/sentry_options.c Outdated Show resolved Hide resolved
@JoshuaMoelans JoshuaMoelans changed the title feat: add log levels (WIP title) feat: add init and logger log levels Dec 18, 2024
@JoshuaMoelans JoshuaMoelans changed the title feat: add init and logger log levels feat: add sentry_init and global logger log levels Dec 18, 2024
@JoshuaMoelans JoshuaMoelans marked this pull request as ready for review December 18, 2024 15:31
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected the macro name change to highlight a few inconsistencies.

A short sync might also be acceptable regarding the options interface.

include/sentry.h Outdated Show resolved Hide resolved
src/backends/sentry_backend_crashpad.cpp Outdated Show resolved Hide resolved
src/backends/sentry_backend_crashpad.cpp Outdated Show resolved Hide resolved
src/path/sentry_path_unix.c Outdated Show resolved Hide resolved
src/path/sentry_path_windows.c Outdated Show resolved Hide resolved
src/sentry_transport.c Outdated Show resolved Hide resolved
src/sentry_transport.c Outdated Show resolved Hide resolved
src/transports/sentry_transport_winhttp.c Outdated Show resolved Hide resolved
src/sentry_core.c Outdated Show resolved Hide resolved
src/sentry_core.c Outdated Show resolved Hide resolved
@JoshuaMoelans JoshuaMoelans changed the title feat: add sentry_init and global logger log levels feat: add global logger log levels Dec 19, 2024
@JoshuaMoelans JoshuaMoelans changed the title feat: add global logger log levels feat: add option to set debug log level Dec 19, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@JoshuaMoelans JoshuaMoelans merged commit b24b30c into master Dec 19, 2024
24 checks passed
@JoshuaMoelans JoshuaMoelans deleted the joshua/feat/init_output_level branch December 19, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to output warnings from sentry_init()
2 participants