-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to set debug log level #1107
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 82.57% 82.49% -0.08%
==========================================
Files 53 53
Lines 7889 7896 +7
Branches 1232 1234 +2
==========================================
Hits 6514 6514
- Misses 1263 1270 +7
Partials 112 112 |
sentry_init
and global logger log levels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected the macro name change to highlight a few inconsistencies.
A short sync might also be acceptable regarding the options interface.
sentry_init
and global logger log levels
Fixes #888
Related to getsentry/sentry-cocoa#4467
The main goal is to allow for outputting just the warnings from
sentry_init
. To accommodate this, we introduce log levels as a way to control what level of output the user gets. We decided against splitting up these levels intoinit
-only and global levels, since this doesn't seem like a necessary feature as of yet.