feat(core): Add shared flushIfServerless function
#17177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| })(), | ||
| ); | ||
| await flushIfServerless(); |
There was a problem hiding this comment.
Bug: Blocking Behavior in Non-Vercel Serverless Environments
The change from vercelWaitUntil to await flushIfServerless() introduces blocking behavior in serverless environments other than Vercel or Cloudflare (e.g., AWS Lambda, Google Cloud Functions). While flushIfServerless uses non-blocking approaches for Vercel/Cloudflare, it falls back to a blocking await flush() in other environments, potentially impacting middleware performance and response times.
Locations (1)
s1gr1d
force-pushed
the
sig/flushIfServerless-core
branch
from
6229acd to
4478ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for this PR: #17168
Creating a shared function
flushIfServerlessas this functionality is used quite often in various SDKs.