-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core)!: Always use session from isolation scope #14860
Open
mydea
wants to merge
9
commits into
develop
Choose a base branch
from
fn/session-currentScope
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
mydea
force-pushed
the
fn/session-currentScope
branch
from
December 30, 2024 15:41
0a3e7a2
to
c0ca43d
Compare
This is more behavioural breaking, for general usage this should not change anything.
mydea
force-pushed
the
fn/session-currentScope
branch
from
January 2, 2025 08:05
d0d8339
to
a80d35a
Compare
mydea
changed the title
ref(core): Stop setting session on current scope
feat(core): Always use session from isolation scope
Jan 2, 2025
mydea
changed the title
feat(core): Always use session from isolation scope
feat(core)!: Always use session from isolation scope
Jan 2, 2025
Lms24
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we always take the session from the isolation scope, never from the current scope.
This has the implication that we need to be sure to pass the isolation scope to
_processEvent
, as this is where the session may be marked as errored. For this, I updated the internal method_processEvent
to take the isolation scope as last argument, as well as streamlining this slightly.I opted to update the signature of the protected
_prepareEvent
method too, and make currentScope/isolationScope required there. We already always pass this in now, so it safes a few bytes to avoid the fallback everywhere. This should not really affect users unless they overwrite the_processEvent
method, which is internal/private anyhow, so IMHO this should be fine. I added a small note to the migration guide anyhow!