perf(connectivity): Have only one NetworkCallback active at a time #4562

romtsn · 2025-07-18T14:24:00Z

📜 Description

Have only single NetworkCallback registered at a time
- Multi-cast it to the internal child NetworkCallbacks (NetworkBreadcrumbsIntegration)
Remove executor in NetworkBreadcrumbsIntegration since we just add a callback to the list now instead of doing any IPC
While testing it I noticed replay wasn't always catching network_available breadcrumb due to timing issues, so I special-cased it in this PR too

Event example: https://sentry-sdks.sentry.io/issues/6560149804/events/960094050aa341cca6ac9d0c175f699e/
Replay example: https://sentry-sdks.sentry.io/explore/replays/fff819393dd44cfa9a06b54255664529

💡 Motivation and Context

Less IPC

💚 How did you test it?

Manually + automated

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…PC calls

romtsn · 2025-07-18T14:28:22Z

sentry-android-core/src/main/java/io/sentry/android/core/NetworkBreadcrumbsIntegration.java

+                scopes, buildInfoProvider, options.getDateProvider());
+
+        final boolean registered =
+            AndroidConnectionStatusProvider.addNetworkCallback(


one caveat: This now will not emit AVAILABLE and CAPABILITIES_CHANGED callbacks immediately after registration as opposed to calling ConnectivityManager.registerDefaultNetworkCallback.

But I think it's fine and how it should be - previously any event would always start with NETWORK_AVAILABLE breadcrumb, which could have been misleading, now we're actually adding breadcrumbs whenever there's a change.

romtsn · 2025-07-18T14:29:22Z

sentry-android-core/src/main/java/io/sentry/android/core/SendCachedEnvelopeIntegration.java

-    if (scopes != null && options != null) {
+    if (scopes != null
+        && options != null
+        && status != IConnectionStatusProvider.ConnectionStatus.DISCONNECTED) {


kind of unrelated to this PR, but I noticed that we also submit a task even if the status was DISCONNECTED, which was unnecessary since we'd anyway bail out in the submitted task itself.

github-actions · 2025-07-18T14:32:36Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	478.24 ms	525.98 ms	47.74 ms
Size	1.58 MiB	2.09 MiB	521.57 KiB

Previous results on branch: rz/perf/single-network-callback

Startup times

Revision	Plain	With Sentry	Diff
`5993034`	471.84 ms	493.10 ms	21.26 ms
`c2f723e`	382.31 ms	432.96 ms	50.65 ms

App size

Revision	Plain	With Sentry	Diff
`5993034`	1.58 MiB	2.09 MiB	520.98 KiB
`c2f723e`	1.58 MiB	2.09 MiB	520.98 KiB

...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java

…4562)

* Do not report cached events as lost * E2E tests for OpenTelemetry based console sample (#4563) * e2e tests for console app * fix test failures by waiting for 10s after first try to find envelopes * add system-test-runner.py script to replace bash scripts for running e2e / system tests * use py script for ci, cleanup, makefile * Format code * remove bash scripts * install requests module * api * fix gh script * Implement E2E tests for OTel based console sample * fixes after merge * Format code * e2e tests for console app * Implement E2E tests for OTel based console sample * fixes after merge * Format code * api * Reduce scope forking when using OpenTelemetry (#4565) * Reduce scope forking in OpenTelemetry * Format code * api * changelog --------- Co-authored-by: Sentry Github Bot <[email protected]> * SDKs send queue is no longer shutdown immediately on re-init (#4564) * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * adapt tests * changelog --------- Co-authored-by: Sentry Github Bot <[email protected]> --------- Co-authored-by: Sentry Github Bot <[email protected]> * release: 8.18.0 * ref(replay): Use main thread to schedule capture (#4542) * perf(connectivity): Cache network capabilities and status to reduce IPC calls (#4560) * fix(breadcrumbs): Deduplicate battery breadcrumbs (#4561) * fix(ci): remove obsolete NDK debug symbols (#4581) As they don't exist anymore and this is done within sentry-native directly: https://github.com/getsentry/sentry-native/pull/1327/files * fix(android): Remove unused method (#4585) * fix(android): Remove unused method * Update Changelog * Add rules file for documenting SDK offline behaviour (#4572) #skip-changelog ## 📜 Description  Add rules file for documenting SDK offline behaviour ## 💡 Motivation and Context   Should help speed up AI reasoning about the SDK offline/retry behaviour. ## 💚 How did you test it? ## 📝 Checklist  - [ ] I added tests to verify the changes. - [ ] No new PII added or SDK only sends newly added PII if `sendDefaultPII` is enabled. - [ ] I updated the docs if needed. - [ ] I updated the wizard if needed. - [ ] Review from the native team if needed. - [ ] No breaking change or entry added to the changelog. - [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs. ## 🔮 Next steps * perf(connectivity): Have only one NetworkCallback active at a time (#4562) * fix(scripts): update-gradle script set-version (#4591) * fix: sentry-android-ndk proguard rule keeps all native class (#4427) * fix: sentry-androi-ndk proguard rule keeps all native class * docs: update CHANGELOG * fix: update CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Markus Hintersteiner <[email protected]> Co-authored-by: Markus Hintersteiner <[email protected]> * refactor(lifecycle): Use single lifecycle observer (#4567) * perf(connectivity): Cache network capabilities and status to reduce IPC calls * changelog * Changelog * revert * fix(breadcrumbs): Deduplicate battery breadcrumbs * ref * Changelog * Fix test * perf(connectivity): Have only one NetworkCallback active at a time * Changelog * perf(integrations): Use single lifecycle observer * Add tests * Changelog * Fix tests * Improve callback handling and test visibility (#4593) * Null-check lifecycleObserver --------- Co-authored-by: Markus Hintersteiner <[email protected]> * fix(sqlite): Fix abstract method error (#4597) * fix(sqlite): Fix abstract method error * Update CHANGELOG.md * Suppress metadata version checks * perf(integrations): Do not register for SystemEvents and NetworkCallbacks when launched with background importance (#4579) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread (#4582) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread * Fix race conditions * Update Changelog * Update CHANGELOG.md * Address PR feedback * perf(executor): Prewarm SentryExecutorService (#4606) * review feedback * changelog * pass through whether cache stored in AndroidEnvelopeCache + test * Format code --------- Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: Roman Zavarnitsyn <[email protected]> Co-authored-by: Markus Hintersteiner <[email protected]> Co-authored-by: Ghasem Shirdel <[email protected]> Co-authored-by: Markus Hintersteiner <[email protected]>

romtsn added 11 commits July 16, 2025 12:34

perf(connectivity): Cache network capabilities and status to reduce I…

2a0d6da

…PC calls

Merge branch 'main' into rz/perf/less-ipc

0ac3081

changelog

14bb2d5

Changelog

c82586d

revert

7418781

fix(breadcrumbs): Deduplicate battery breadcrumbs

f739d00

ref

833b026

Changelog

e4596ff

Fix test

0153ab5

Merge branch 'rz/perf/less-ipc' into rz/fix/diff-battery-crumbs

15794c6

perf(connectivity): Have only one NetworkCallback active at a time

c31d648

romtsn requested review from adinauer, stefanosiano, markushi and lcian as code owners July 18, 2025 14:24

romtsn commented Jul 18, 2025

View reviewed changes

Changelog

83d80d7

Remove obsolete tests

d4d7816

markushi approved these changes Jul 22, 2025

View reviewed changes

Base automatically changed from rz/fix/diff-battery-crumbs to main July 30, 2025 22:16

Merge branch 'main' into rz/perf/single-network-callback

aa6dd68

cursor bot reviewed Aug 1, 2025

View reviewed changes

...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java Show resolved Hide resolved

romtsn merged commit 617a292 into main Aug 1, 2025
35 of 36 checks passed

romtsn deleted the rz/perf/single-network-callback branch August 1, 2025 13:29

adinauer pushed a commit that referenced this pull request Aug 8, 2025

perf(connectivity): Have only one NetworkCallback active at a time (#…

e45908a

…4562)

antonis mentioned this pull request Aug 11, 2025

chore(deps): v7: update Android SDK to v8.19.0 getsentry/sentry-react-native#5063

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(connectivity): Have only one NetworkCallback active at a time #4562

perf(connectivity): Have only one NetworkCallback active at a time #4562

Uh oh!

romtsn commented Jul 18, 2025

Uh oh!

romtsn Jul 18, 2025

Uh oh!

romtsn Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

Previous results on branch: rz/perf/single-network-callback

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

perf(connectivity): Have only one NetworkCallback active at a time #4562

perf(connectivity): Have only one NetworkCallback active at a time #4562

Uh oh!

Conversation

romtsn commented Jul 18, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

romtsn Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

romtsn Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Previous results on branch: rz/perf/single-network-callback

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading