Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Wrap exceptions groups #4055

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adinauer
Copy link
Member

Wrap exceptions when there is a suppressed exception and mark the wrapper as group.

Screenshot 2025-01-15 at 17 15 57

📜 Description

💡 Motivation and Context

A potential fix for #4054 but it introduces a wrapper object which we'd have to explain to our customers and which makes it harder to read the issue in Sentry UI due to the artificial wrapper exception that shows up like a normal exception on the issue detail page.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Wrap exceptions groups ([#4055](https://github.com/getsentry/sentry-java/pull/4055))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 82810f5

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 677.96 ms 772.38 ms 94.42 ms
Size 1.65 MiB 2.31 MiB 677.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant