Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 36 - POC Capture OpenTelemetry Events #3564

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adinauer
Copy link
Member

📜 Description

OpenTelemetry spans can have events attached. This PR allows us to capture exceptions from ExceptionEventData into Sentry if the captureOpenTelemetryEvents option is enabled.

💡 Motivation and Context

Allows us to capture more errors. Doesn't require extra Sentry dependencies on the application for capturing errors - the agent alone is enough to capture errors.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer changed the base branch from main to 8.x.x July 11, 2024 07:42
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 36 - POC Capture OpenTelemetry Events ([#3564](https://github.com/getsentry/sentry-java/pull/3564))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 20f0c8c

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 435.23 ms 477.22 ms 42.00 ms
Size 1.70 MiB 2.29 MiB 599.53 KiB

Base automatically changed from 8.x.x to main January 9, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant