Repository navigation
fix(sentry-kube): Print the credential fetch command to stderr - #261
Merged
Merged
Conversation
When a cluster's credentials aren't in the kubeconfig yet, sentry-kube prints the gcloud get-credentials command it runs to stdout, ahead of the command's own output. That corrupts machine-readable output such as `cluster nodepools -o json` on the first run against a cluster. Print it to stderr, like the similar message in libsentrykube/utils.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tpq2osA9FtohCFSg6dmBwF
mwarkentin
enabled auto-merge (squash)
October 15, 2026 20:24
BojanOro
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a cluster's credentials aren't in the kubeconfig yet,
ensure_iap_tunnelfetches them and prints the command it runs (Running: gcloud container clusters get-credentials ...) to stdout, ahead of the command's own output. On the first run against a cluster, that breaks machine-readable output, e.g.:This prints the line to stderr instead, matching the similar "Context not in kubeconfig. Adding cluster credentials with: ..." message in
libsentrykube/utils.py. Interactive runs still show it.Test plan
test_get_cluster_credentials_successnow asserts the message is printed witherr=True(fails without the fix)kube-linterbinary,kubernetesclient version)pre-commit(ruff, ruff format, mypy) on the changed files🤖 Generated with Claude Code
https://claude.ai/code/session_01Tpq2osA9FtohCFSg6dmBwF
Generated by Claude Code