-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Verify to 28.5.0 #3845
Update Verify to 28.5.0 #3845
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3845 +/- ##
==========================================
+ Coverage 75.73% 76.52% +0.79%
==========================================
Files 357 389 +32
Lines 13466 14207 +741
Branches 2671 2858 +187
==========================================
+ Hits 10198 10872 +674
- Misses 2593 2641 +48
- Partials 675 694 +19 ☔ View full report in Codecov by Sentry. |
@jamescrosswell given the CI passed, can we assume this fixes https://github.com/orgs/VerifyTests/discussions/1366 ? |
Hey @SimonCropp - possibly. I upgraded to Verify 26.6.0 a couple of weeks back. I bumped into a slightly different issue there (documented in the details for that PR) and eventually had to disable one of the tests in CI since I couldn't get to the bottom of it. I suspect that's a different issue to the one I raised in the discussion forum though. It may well be a Sentry thing rather than a Verify thing (which is why I didn't raise it in the Verify repository). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SimonCropp !
@jamescrosswell how long do u intend to support mono for? |
#skip-changelog