Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Verify to 28.5.0 #3845

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Dec 13, 2024

#skip-changelog

@SimonCropp SimonCropp marked this pull request as draft December 13, 2024 09:11
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.52%. Comparing base (495e742) to head (34552f2).
Report is 412 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3845      +/-   ##
==========================================
+ Coverage   75.73%   76.52%   +0.79%     
==========================================
  Files         357      389      +32     
  Lines       13466    14207     +741     
  Branches     2671     2858     +187     
==========================================
+ Hits        10198    10872     +674     
- Misses       2593     2641      +48     
- Partials      675      694      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonCropp SimonCropp changed the title Please ignore Update Verify to 28.5.0 Dec 13, 2024
@SimonCropp SimonCropp marked this pull request as ready for review December 13, 2024 09:28
@SimonCropp
Copy link
Contributor Author

@jamescrosswell given the CI passed, can we assume this fixes https://github.com/orgs/VerifyTests/discussions/1366 ?

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Dec 15, 2024

https://github.com/orgs/VerifyTests/discussions/1366

Hey @SimonCropp - possibly.

I upgraded to Verify 26.6.0 a couple of weeks back. I bumped into a slightly different issue there (documented in the details for that PR) and eventually had to disable one of the tests in CI since I couldn't get to the bottom of it.

I suspect that's a different issue to the one I raised in the discussion forum though. It may well be a Sentry thing rather than a Verify thing (which is why I didn't raise it in the Verify repository).

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SimonCropp !

@jamescrosswell jamescrosswell merged commit 50251b2 into getsentry:main Dec 17, 2024
22 of 24 checks passed
@SimonCropp
Copy link
Contributor Author

@jamescrosswell how long do u intend to support mono for?

@SimonCropp SimonCropp deleted the update-Verify branch December 17, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants