Skip to content

Conversation

@a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Oct 24, 2025

Changes

  • Imrpoved gh action cache logic

TODO

There are some 404s that slipped through while the linter was not working.

We should fix them before merging to not block other PRs.

On Devloper Docs

On user facing docs

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Oct 24, 2025 9:55pm
sentry-docs Ready Ready Preview Comment Oct 24, 2025 9:55pm

@codecov
Copy link

codecov bot commented Oct 24, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/Gneym57OKDwmASijUVFAm/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/Gneym57OKDwmASijUVFAm/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/c-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/c-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@a-hariti a-hariti changed the title change gh action cache logic Fix 404 linter Oct 24, 2025
@a-hariti a-hariti marked this pull request as ready for review October 24, 2025 18:34
@a-hariti a-hariti requested a review from sfanahata October 24, 2025 18:35
cursor[bot]

This comment was marked as outdated.

@sfanahata
Copy link
Contributor

I can help fix those links.

@sfanahata
Copy link
Contributor

@a-hariti

/platforms/javascript/guides/aws-lambda/install/layer__v8.x

manually
ESM guide

Looks like this doesn't exist anymore. We only show v9.x as a supported version.

@sfanahata
Copy link
Contributor

PR that fixes the broken links: #15316

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. The build still renders. I guess we just need to test it against production now! Linked the related PR that fixes the broken links ahead of merging this one.

sfanahata added a commit that referenced this pull request Oct 29, 2025
…#15316)

## DESCRIBE YOUR PR
Related to #15312
Fixed broken links that the 404 linter didn't catch while it was broken.

## On Devloper Docs

- 🌐
http://localhost:3000/sdk/telemetry/profiles/continuous-profiling-api
    - `[Replay session](/product/explore/session-replay/web/)`
-  🌐 http://localhost:3000/sdk/telemetry/traces/modules/ai-agents
    - `[general size limits](/concepts/data-management/size-limits/)`

## On user facing docs

- 🌐
http://localhost:3000/security-legal-pii/security/data-retention-periods
     - `[Uptime](/product/monitoring/)`
     - `[Attachments](/product/issues/issue-details/attachments/)`
- 🌐
http://localhost:3000/platforms/javascript/guides/aws-lambda/install__v9.x
    - `[using our Lambda Layer (recommended)](./install/layer__v9.x)`
    -` [installing the Sentry AWS NPM package](./install/cjs-npm__v9.x)`
    - `[ESM instructions](./install/esm-npm__v9.x)`
- 🌐
http://localhost:3000/platforms/javascript/guides/cloudflare/sourcemaps
- `[Cloudflare Workers
guide](/platforms/javascript/sourcemaps/uploading/wrangler/)`
-  🌐 http://localhost:3000/platforms/javascript/guides/nuxt/sourcemaps
- `[source maps
options](/platforms/javascript/guides/nuxt/configuration/build/#source-maps-options)`
- 🌐
http://localhost:3000/platforms/javascript/guides/solidstart/sourcemaps
    - `[Manual Configuration](../overview/javascript.solidstart.mdx)`
- `[source maps
options](/platforms/javascript/guides/solidstart/configuration/build/#source-maps-options)`
- 🌐
http://localhost:3000/platforms/javascript/guides/aws-lambda/install/layer__v9.x
    - `[manually](../cjs-npm)`
    - `[ESM guide](../esm-npm)`
- 🌐
http://localhost:3000/platforms/javascript/guides/cordova/configuration/options
    - Obscured CORS docs because it doesn't apply to Cordova
- 🌐
http://localhost:3000/platforms/javascript/guides/electron/configuration/options
- `[Custom IPC Namespace
section](/platforms/javascript/guides/electron/platforms/javascript/guides/electron/#custom-ipc-namespace)`
- 🌐
http://localhost:3000/platforms/javascript/guides/aws-lambda/configuration/lambda-wrapper
- `[initializing the SDK in
code](../../install/cjs-layer#alternative-initialize-the-sdk-in-code)`
- 🌐
http://localhost:3000/platforms/javascript/guides/aws-lambda/install/npm__v9.x
    - `[CommonJS instructions](./cjs-npm__v9.x)`
    - `[ESM instructions](./esm-npm__v9.x)`
    - `[CommonJS instructions](./cjs-npm__v9.x)`
    - `[ESM instructions](./esm-npm__v9.x)`
- 🌐
http://localhost:3000/platforms/javascript/guides/aws-lambda/install/cjs-npm__v9.x
    - `[Lambda Layer](../cjs-layer)`
- 🌐
http://localhost:3000/platforms/javascript/guides/electron/configuration/environments
- `[Custom IPC Namespace
section](/platforms/javascript/guides/electron/platforms/javascript/guides/electron/#custom-ipc-namespace)`
- 🌐
http://localhost:3000/platforms/javascript/guides/aws-lambda/configuration/integrations/unhandledrejection
- `[manually
wrapped](/platforms/javascript/guides/aws-lambda/install/cjs-layer/#alternative-initialize-the-sdk-in-code)`

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

---------

Co-authored-by: Shannon Anahata <[email protected]>
Co-authored-by: Abdellah Hariti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants