Skip to content

feat(android/java): document Ktor Client integration #14457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 30, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jul 25, 2025

DESCRIBE YOUR PR

  • Docs for Add Ktor client integration sentry-java#4527
  • Mainly took the OkHttp docs and asked Cursor to adapt them to the new integration by using the code as context, with some manual changes.
  • Also adds a docs page for it for Java. Changes wrt Android docs:
    • Don't mention SAGP
    • Use the JVM client engine instead of Android
    • Sentry.init instead of SentryAndroid.init

Copy link

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) Jul 29, 2025 9:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 9:27am

@codeowner-assignment codeowner-assignment bot requested a review from a team July 25, 2025 09:06
Copy link

codecov bot commented Jul 25, 2025

Bundle Report

Changes will increase total bundle size by 5.96kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.83MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.25MB 5.97kB (0.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 1.99kB 728.05kB 0.27%
../app/platform-redirect/page.js.nft.json 1.99kB 727.96kB 0.27%
../app/sitemap.xml/route.js.nft.json 1.99kB 725.44kB 0.28%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 879.71kB -0.0%
static/chunks/1831-*.js -3 bytes 422.23kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/XxaNbVYFePLk_QfO7WTaz/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/XxaNbVYFePLk_QfO7WTaz/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/YXY4G8VURQGtd11K3TBRI/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/YXY4G8VURQGtd11K3TBRI/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@lcian lcian changed the title feat(android): document Ktor Client integration feat(android/java): document Ktor Client integration Jul 25, 2025
@codeowner-assignment codeowner-assignment bot requested a review from a team July 25, 2025 09:51
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions, but overall looks great! Thanks for adding 🫡

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@codeowner-assignment codeowner-assignment bot requested a review from a team July 29, 2025 08:58
@lcian lcian merged commit ecdd0ed into master Jul 30, 2025
13 checks passed
@lcian lcian deleted the lcian/feat/java-ktor-client-docs branch July 30, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants