-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform): Update onboarding options on tab switch #12913
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.42kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
Files in
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
Files in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @chargome !
@chargome thanks for tackling this! just want to add that refreshing the page on a different tab than the first also shows the same behaviour |
@kahest not sure what you mean exactly, can you give me an example? |
@chargome on the iOS docs for example, go to the Toggling e.g. After refreshing the page though, the original behaviour shows: It's not a huge problem, but it seems likely to have the same root cause and would be nice to fix in this PR if possible. |
@kahest I think this is already solved with this pr: https://sentry-docs-git-cg-fix-onboarding-options-java.sentry.dev/platforms/apple/guides/ios/ |
@chargome yes, perfect 🥇 |
codeContext
closes #12726