Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add Troubleshooting item for "clicks in wrong places" #12782

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 19, 2025

Adds a troubleshooting entry for when clicks are in the wrong location (e.g. it looks like it is clicking nothing, but it should be clicking a checkbox or button).

ref: getsentry/sentry-javascript#15449

https://sentry.slack.com/archives/C03USURCFBJ/p1739781759800659

Adds a troubleshooting entry for when clicks are in the wrong location (e.g. it looks like it is clicking nothing, but it should be clicking a checkbox or button).

ref: getsentry/sentry-javascript#15449

https://sentry.slack.com/archives/C03USURCFBJ/p1739781759800659
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:19pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 8:19pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 8:19pm

@billyvg billyvg requested a review from jas-kas February 19, 2025 22:34
@billyvg billyvg marked this pull request as ready for review February 19, 2025 22:34
Copy link

codecov bot commented Feb 19, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/sl5U-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/sl5U-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/1YkbTd4zmBuamvDAhdUlQ/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/1YkbTd4zmBuamvDAhdUlQ/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%

@billyvg
Copy link
Member Author

billyvg commented Feb 24, 2025

Hmm actually these instructions are a bit wrong, will update them tomorrow.

@billyvg
Copy link
Member Author

billyvg commented Feb 26, 2025

@coolguyzone can you take another look at this when you get a chance? Thanks!

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@billyvg billyvg merged commit e2a5582 into master Mar 4, 2025
11 checks passed
@billyvg billyvg deleted the feat-replay-troubleshooting-misaligned-clicks branch March 4, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants