Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): Add image cards to devdocs getting started page #12110

Merged
merged 11 commits into from
Jan 31, 2025

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Dec 12, 2024

Updates the dev docs getting started page to use new images with the same Card component that is used in user docs.

Preview:
https://develop-docs-git-antonpirker-developstartpage.sentry.dev/getting-started/

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 5:40pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 5:40pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 5:40pm

Copy link

codecov bot commented Dec 12, 2024

Bundle Report

Changes will increase total bundle size by 228.26kB (1.12%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.79MB 162.1kB (1.52%) ⬆️
sentry-docs-client-array-push 9.38MB 66.16kB (0.71%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 866.04kB -0.0%
static/css/*.css 61 bytes 739.24kB 0.01%
static/css/*.css 17 bytes 17.02kB 0.1%
static/chunks/9557-*.js -3 bytes 391.11kB -0.0%
server/app/_not-*.js 4.41kB 251.6kB 1.78%
server/app/[[...path]]/page_client-*.js 4.41kB 251.56kB 1.78%
server/app/platform-*.js 4.41kB 236.89kB 1.9%
static/chunks/app/[[...path]]/page-*.js 4.05kB 71.17kB 6.03% ⚠️
/static/media/front-*.9aa699a3.png (New) 8.48kB 8.48kB 100.0% 🚀
/static/media/dev-*.baf528bf.png (New) 8.3kB 8.3kB 100.0% 🚀
/static/media/sdks.*.png (New) 8.23kB 8.23kB 100.0% 🚀
/static/media/services.*.png (New) 7.89kB 7.89kB 100.0% 🚀
/static/media/back-*.086715f4.png (New) 5.88kB 5.88kB 100.0% 🚀
/static/media/ingest.*.png (New) 5.11kB 5.11kB 100.0% 🚀
/static/media/integrate.*.png (New) 4.93kB 4.93kB 100.0% 🚀
static/a3TaWnUWa5Zccn4GsMmKo/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/a3TaWnUWa5Zccn4GsMmKo/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/l80_Bm3Ieee2gGuZzW-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/l80_Bm3Ieee2gGuZzW-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

  • ./src/imgs/back-end.png → Total Size: 532 bytes

  • ./src/imgs/integrate.png → Total Size: 485 bytes

  • ./src/imgs/ingest.png → Total Size: 474 bytes

  • ./src/imgs/services.png → Total Size: 500 bytes

  • ./src/imgs/dev-infra.png → Total Size: 453 bytes

  • ./src/imgs/front-end.png → Total Size: 557 bytes

  • ./src/imgs/sdks.png → Total Size: 500 bytes

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js 33.65kB 1.67MB 2.06%
../instrumentation.js 33.65kB 998.88kB 3.49%
9523.js 33.68kB 975.12kB 3.58%
../app/[[...path]]/page.js 10.7kB 525.11kB 2.08%
../app/[[...path]]/page.js.nft.json 538 bytes 374.52kB 0.14%
../app/platform-redirect/page.js.nft.json 538 bytes 374.43kB 0.14%
../app/sitemap.xml/route.js.nft.json 538 bytes 372.4kB 0.14%
../../static/media/front-end.*.png (New) 8.48kB 8.48kB 100.0% 🚀
../../static/media/dev-infra.*.png (New) 8.3kB 8.3kB 100.0% 🚀
../../static/media/sdks.*.png (New) 8.23kB 8.23kB 100.0% 🚀
../../static/media/services.*.png (New) 7.89kB 7.89kB 100.0% 🚀
../../static/media/back-end.*.png (New) 5.88kB 5.88kB 100.0% 🚀
../../static/media/ingest.*.png (New) 5.11kB 5.11kB 100.0% 🚀
../../static/media/integrate.*.png (New) 4.93kB 4.93kB 100.0% 🚀

Files in ../app/[[...path]]/page.js:

  • ./src/imgs/services.png → Total Size: 500 bytes

  • ./src/imgs/dev-infra.png → Total Size: 453 bytes

  • ./src/imgs/front-end.png → Total Size: 557 bytes

  • ./src/imgs/front-end.png → Total Size: 557 bytes

  • ./src/imgs/sdks.png → Total Size: 500 bytes

  • ./src/imgs/services.png → Total Size: 500 bytes

  • ./src/imgs/back-end.png → Total Size: 532 bytes

  • ./src/components/devDocsCardGrid.tsx → Total Size: 4.39kB

  • ./src/imgs/ingest.png → Total Size: 474 bytes

  • ./src/imgs/ingest.png → Total Size: 474 bytes

  • ./src/imgs/integrate.png → Total Size: 485 bytes

  • ./src/mdxComponents.ts → Total Size: 3.38kB

  • ./src/imgs/back-end.png → Total Size: 532 bytes

  • ./src/imgs/dev-infra.png → Total Size: 453 bytes

  • ./src/components/card.tsx → Total Size: 1.59kB

  • ./src/imgs/sdks.png → Total Size: 500 bytes

  • ./src/imgs/integrate.png → Total Size: 485 bytes

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 10.7kB 3.08MB 0.35%

@getsantry
Copy link
Contributor

getsantry bot commented Jan 11, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jan 11, 2025
@chargome chargome added wip and removed Stale labels Jan 11, 2025
@chargome chargome changed the title Develop Docs Getting-started page nicer. feat(platform): Add image cards to devdocs getting started page Jan 31, 2025
@chargome chargome marked this pull request as ready for review January 31, 2025 07:17
@chargome chargome requested a review from coolguyzone January 31, 2025 07:17
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome.

See two wording suggestions.

src/components/devDocsCardGrid.tsx Outdated Show resolved Hide resolved
src/components/devDocsCardGrid.tsx Outdated Show resolved Hide resolved
@antonpirker antonpirker removed the wip label Jan 31, 2025
@antonpirker antonpirker enabled auto-merge (squash) January 31, 2025 12:08
@chargome chargome disabled auto-merge January 31, 2025 17:31
@chargome chargome merged commit 09db0a2 into master Jan 31, 2025
13 checks passed
@chargome chargome deleted the antonpirker/develop/startpage branch January 31, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants