Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Nov 3, 2025

This PR removes snapshot tests introduced in session replay masking PRs.

The reason is that Swift Package Manager requires a deep clone and we should not further bloat the repository with assets, unless necessary.

We might consider using EmergeTools Snapshots at some point in the near future and partially revert this commit.

#skip-changelog

Closes #6632

@philprime philprime self-assigned this Nov 3, 2025
@philprime philprime changed the title chore(ci): Remove snapshot testing to reduce repository size chore(tests): Remove snapshot testing to reduce repository size Nov 3, 2025
cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.459%. Comparing base (0a40a02) to head (45447b6).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6631       +/-   ##
=============================================
+ Coverage   85.453%   85.459%   +0.006%     
=============================================
  Files          451       451               
  Lines        27566     27565        -1     
  Branches     12069     12070        +1     
=============================================
+ Hits         23556     23557        +1     
+ Misses        3963      3721      -242     
- Partials        47       287      +240     

see 48 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a40a02...45447b6. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.88 ms 1252.45 ms 31.57 ms
Size 23.75 KiB 1.01 MiB 1016.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
827b50c 1233.27 ms 1267.28 ms 34.01 ms
8745cc0 1228.13 ms 1250.48 ms 22.35 ms
ebc72be 1221.24 ms 1249.66 ms 28.42 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
331dad6 1210.40 ms 1242.06 ms 31.67 ms
2bddb03 1214.11 ms 1246.78 ms 32.67 ms
916edbe 1243.86 ms 1256.11 ms 12.25 ms
3b4b557 1234.59 ms 1254.02 ms 19.43 ms
b074ba9 1236.52 ms 1248.75 ms 12.23 ms
25f2d2c 1232.02 ms 1242.78 ms 10.76 ms

App size

Revision Plain With Sentry Diff
827b50c 23.75 KiB 1.00 MiB 1005.07 KiB
8745cc0 23.74 KiB 971.81 KiB 948.07 KiB
ebc72be 23.75 KiB 908.22 KiB 884.47 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
331dad6 23.75 KiB 928.12 KiB 904.37 KiB
2bddb03 23.75 KiB 891.01 KiB 867.26 KiB
916edbe 23.75 KiB 908.41 KiB 884.66 KiB
3b4b557 23.75 KiB 908.39 KiB 884.64 KiB
b074ba9 23.74 KiB 976.79 KiB 953.05 KiB
25f2d2c 23.75 KiB 866.69 KiB 842.94 KiB

Previous results on branch: philprime/remove-snapshot-tests

Startup times

Revision Plain With Sentry Diff
7be73cb 1224.34 ms 1256.90 ms 32.56 ms

App size

Revision Plain With Sentry Diff
7be73cb 23.75 KiB 1.01 MiB 1016.04 KiB

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime enabled auto-merge (squash) November 3, 2025 12:11
@philprime philprime merged commit b1e357f into main Nov 3, 2025
193 of 196 checks passed
@philprime philprime deleted the philprime/remove-snapshot-tests branch November 3, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): Remove snapshot testing to reduce repository size

3 participants