-
-
Notifications
You must be signed in to change notification settings - Fork 372
ref: Rename SentryMechanismMeta to SentryMechanismMetaInformation #6607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Renames SentryMechanismMeta to SentryMechanismContext to resolve naming conflicts with Kotlin Multiplatform's metaprogramming features. Changes: - Rename class from SentryMechanismMeta to SentryMechanismContext - Update Swift name from MechanismMeta to MechanismContext - Update all imports and references across the codebase - Rename test files and update test class names - Update Xcode project and SDK API files Closes #2888
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
FYI @philprime, I pinged Gino if this is still required #2888 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when CI is green and @buenaflor confirms this is still required #2888 (comment).
Thanks @philprime 🚀
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7bb24a2 | 1229.16 ms | 1256.66 ms | 27.50 ms |
| 1f48bb7 | 1223.83 ms | 1241.85 ms | 18.02 ms |
| 1b008ee | 1209.57 ms | 1258.67 ms | 49.10 ms |
| c2982e7 | 1223.92 ms | 1242.86 ms | 18.94 ms |
| a6f5396 | 1211.81 ms | 1245.63 ms | 33.82 ms |
| 94a6b1a | 1213.39 ms | 1231.55 ms | 18.17 ms |
| 736bcfb | 1229.86 ms | 1249.59 ms | 19.73 ms |
| 8d944ac | 1236.92 ms | 1254.91 ms | 18.00 ms |
| 2a07609 | 1207.79 ms | 1233.77 ms | 25.98 ms |
| fc0757d | 1231.83 ms | 1248.98 ms | 17.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7bb24a2 | 23.75 KiB | 973.68 KiB | 949.93 KiB |
| 1f48bb7 | 23.75 KiB | 971.98 KiB | 948.24 KiB |
| 1b008ee | 23.75 KiB | 929.71 KiB | 905.96 KiB |
| c2982e7 | 23.75 KiB | 911.62 KiB | 887.87 KiB |
| a6f5396 | 23.75 KiB | 989.12 KiB | 965.38 KiB |
| 94a6b1a | 23.75 KiB | 902.48 KiB | 878.74 KiB |
| 736bcfb | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 8d944ac | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| 2a07609 | 23.75 KiB | 912.78 KiB | 889.03 KiB |
| fc0757d | 23.75 KiB | 850.73 KiB | 826.98 KiB |
|
@philipphofmann I think we general have issues if Meta is in the name of the class but don't let this block it you, it's not critical at all (https://youtrack.jetbrains.com/issue/KT-41709) Change looks fine for me |
|
@buenaflor the class name would still contain |
|
In that case I agree this refactoring can be avoided unless you think something like |
|
I have already refactored @philipphofmann I do not have a strong opinion on the naming, so even though the field is called |
OK, then let's do |
Description
This PR renames
SentryMechanismMetatoSentryMechanismContextto resolve naming conflicts with Kotlin Multiplatform's metaprogramming features.Closes #2888
Changes
Renamed Classes
SentryMechanismMeta→SentryMechanismContextMechanismMeta→MechanismContextFiles Changed
Created:
Sources/Sentry/Public/SentryMechanismContext.hSources/Sentry/SentryMechanismContext.mSources/Swift/Protocol/Codable/SentryMechanismContextCodable.swiftTests/SentryTests/Protocol/SentryMechanismContextTests.swiftDeleted:
Sources/Sentry/Public/SentryMechanismMeta.hSources/Sentry/SentryMechanismMeta.mSources/Swift/Protocol/Codable/SentryMechanismMetaCodable.swiftTests/SentryTests/Protocol/SentryMechanismMetaTests.swiftUpdated:
Sentry.h,SentryWithoutUIKit.h,SentryMechanism.h)Testing
SentryMechanismContextTestspass on iOSSentryMechanismContextTestspass on macOS