Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 23, 2025

Multiple scripts use the ci-utils.sh as dependencies but the file-filters.yml does not look for changes in transitive dependencies, therefore jobs are not triggered when the file is changed.

Adds the ci-utils.sh to all file filters with at least one script using it

#skip-changelog

Closes #6514

@codecov
Copy link

codecov bot commented Oct 23, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4029 1 4028 28
View the top 2 failed test(s) by shortest run time
SentryTests.SentrySpotlightTransportTests::testShouldRemoveAttachmentsFromEventEnvelope
Stack Traces | 0s run time
.../SentryTests/Networking/SentrySpotlightTransportTests.swift:106 - XCTAssertTrue failed - Expected body size to be in range of 1100...1140, but was 1099
iOS_SwiftUI_UITests.LaunchUITests::testNoNewTransactionForSecondCallToBody
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:37 - Failed to tap "Form Screen" Button: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1190.77 ms 1227.24 ms 36.47 ms
Size 23.75 KiB 1.00 MiB 1005.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4b3f1af 1227.04 ms 1253.35 ms 26.31 ms
b0e13a7 1227.71 ms 1245.88 ms 18.16 ms
3e12a49 1218.13 ms 1260.57 ms 42.44 ms
9e0030e 1222.78 ms 1242.23 ms 19.45 ms
e0a15a5 1230.53 ms 1266.35 ms 35.82 ms
e43ed75 1221.79 ms 1260.68 ms 38.89 ms
9a32d52 1215.69 ms 1236.85 ms 21.16 ms
d06a4db 1233.20 ms 1243.18 ms 9.98 ms
aa96485 1215.37 ms 1234.04 ms 18.67 ms
f43a482 1219.00 ms 1245.56 ms 26.56 ms

App size

Revision Plain With Sentry Diff
4b3f1af 23.75 KiB 981.30 KiB 957.56 KiB
b0e13a7 23.75 KiB 860.98 KiB 837.23 KiB
3e12a49 23.75 KiB 1.01 MiB 1006.48 KiB
9e0030e 23.75 KiB 893.72 KiB 869.97 KiB
e0a15a5 23.75 KiB 979.10 KiB 955.35 KiB
e43ed75 23.74 KiB 1022.92 KiB 999.18 KiB
9a32d52 23.75 KiB 981.29 KiB 957.54 KiB
d06a4db 23.75 KiB 913.18 KiB 889.43 KiB
aa96485 23.75 KiB 874.46 KiB 850.71 KiB
f43a482 23.75 KiB 928.16 KiB 904.41 KiB

Previous results on branch: philprime/fix-file-filter

Startup times

Revision Plain With Sentry Diff
c612239 1222.40 ms 1249.56 ms 27.17 ms

App size

Revision Plain With Sentry Diff
c612239 23.75 KiB 1.01 MiB 1006.48 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime enabled auto-merge (squash) October 24, 2025 07:25
@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Oct 24, 2025
@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): Add ci-utils.sh to file-filters.yml

3 participants