Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 21, 2025

Remove this setting that is deprecated and removed in the v9 flag

#skip-changelog

Closes #6544

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.479%. Comparing base (e648312) to head (0e1f0ef).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6492       +/-   ##
=============================================
- Coverage   85.485%   85.479%   -0.006%     
=============================================
  Files          451       451               
  Lines        27428     27424        -4     
  Branches     11934     11935        +1     
=============================================
- Hits         23447     23442        -5     
- Misses        3697      3937      +240     
+ Partials       284        45      -239     
Files with missing lines Coverage Δ
SentryTestUtils/TestOptions.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 96.407% <ø> (-0.085%) ⬇️
Sources/Sentry/SentrySDKInternal.m 83.266% <ø> (-3.452%) ⬇️
Sources/Sentry/SentyOptionsInternal.m 99.543% <ø> (-0.017%) ⬇️

... and 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e648312...0e1f0ef. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1195.38 ms 1218.21 ms 22.83 ms
Size 23.75 KiB 1.01 MiB 1016.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
748df9d 1231.63 ms 1259.47 ms 27.84 ms
13bc1aa 1244.04 ms 1262.89 ms 18.85 ms
aa0b738 1236.78 ms 1253.08 ms 16.31 ms
dba2de8 1231.45 ms 1251.88 ms 20.43 ms
9be5373 1215.92 ms 1239.44 ms 23.52 ms
ef2c9b3 1222.12 ms 1253.96 ms 31.84 ms
7bd90de 1233.48 ms 1249.47 ms 15.99 ms
53b722c 1222.33 ms 1244.90 ms 22.56 ms
a6f5396 1211.81 ms 1245.63 ms 33.82 ms
62f8d2a 1226.24 ms 1249.92 ms 23.67 ms

App size

Revision Plain With Sentry Diff
748df9d 23.75 KiB 902.48 KiB 878.74 KiB
13bc1aa 23.75 KiB 908.40 KiB 884.65 KiB
aa0b738 23.74 KiB 872.75 KiB 849.00 KiB
dba2de8 23.75 KiB 969.25 KiB 945.50 KiB
9be5373 23.75 KiB 866.50 KiB 842.75 KiB
ef2c9b3 23.75 KiB 933.03 KiB 909.29 KiB
7bd90de 23.75 KiB 933.33 KiB 909.58 KiB
53b722c 23.75 KiB 906.08 KiB 882.33 KiB
a6f5396 23.75 KiB 989.12 KiB 965.38 KiB
62f8d2a 23.75 KiB 926.80 KiB 903.05 KiB

Previous results on branch: removeDeprecatedIntegrations

Startup times

Revision Plain With Sentry Diff
2b2ee5a 1237.29 ms 1265.98 ms 28.69 ms
e207d9e 1237.60 ms 1271.82 ms 34.21 ms
75209a9 1217.91 ms 1248.78 ms 30.87 ms
ff29e12 1214.66 ms 1248.91 ms 34.25 ms
08c8d7a 1220.77 ms 1260.15 ms 39.38 ms
d35abd8 1219.20 ms 1258.71 ms 39.50 ms

App size

Revision Plain With Sentry Diff
2b2ee5a 23.75 KiB 1.00 MiB 1005.77 KiB
e207d9e 23.75 KiB 1.01 MiB 1016.23 KiB
75209a9 23.75 KiB 1.00 MiB 1005.77 KiB
ff29e12 23.75 KiB 1.01 MiB 1006.39 KiB
08c8d7a 23.75 KiB 1.00 MiB 1002.23 KiB
d35abd8 23.75 KiB 1.01 MiB 1008.62 KiB

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch 3 times, most recently from 87033d4 to 310a2a6 Compare October 23, 2025 16:50
@noahsmartin noahsmartin marked this pull request as ready for review October 27, 2025 15:34
cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 310a2a6 to 85715ad Compare October 27, 2025 16:32
cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 85715ad to 51eada2 Compare October 27, 2025 16:49
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch 2 times, most recently from 341c2cc to 3750705 Compare October 28, 2025 18:19
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup, left minor comments, but other than that LGTM

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 3750705 to 7c0af00 Compare October 29, 2025 15:20
cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch 2 times, most recently from df6c3dd to 59e2ffa Compare October 29, 2025 16:22
@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 59e2ffa to 0e1f0ef Compare October 29, 2025 16:51
@noahsmartin noahsmartin merged commit 5ff1b04 into main Oct 29, 2025
173 of 175 checks passed
@noahsmartin noahsmartin deleted the removeDeprecatedIntegrations branch October 29, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Remove deprecated integrations option

4 participants