-
-
Notifications
You must be signed in to change notification settings - Fork 371
ref: Remove deprecated integrations option #6492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6492 +/- ##
=============================================
- Coverage 85.485% 85.479% -0.006%
=============================================
Files 451 451
Lines 27428 27424 -4
Branches 11934 11935 +1
=============================================
- Hits 23447 23442 -5
- Misses 3697 3937 +240
+ Partials 284 45 -239
... and 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 748df9d | 1231.63 ms | 1259.47 ms | 27.84 ms |
| 13bc1aa | 1244.04 ms | 1262.89 ms | 18.85 ms |
| aa0b738 | 1236.78 ms | 1253.08 ms | 16.31 ms |
| dba2de8 | 1231.45 ms | 1251.88 ms | 20.43 ms |
| 9be5373 | 1215.92 ms | 1239.44 ms | 23.52 ms |
| ef2c9b3 | 1222.12 ms | 1253.96 ms | 31.84 ms |
| 7bd90de | 1233.48 ms | 1249.47 ms | 15.99 ms |
| 53b722c | 1222.33 ms | 1244.90 ms | 22.56 ms |
| a6f5396 | 1211.81 ms | 1245.63 ms | 33.82 ms |
| 62f8d2a | 1226.24 ms | 1249.92 ms | 23.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 748df9d | 23.75 KiB | 902.48 KiB | 878.74 KiB |
| 13bc1aa | 23.75 KiB | 908.40 KiB | 884.65 KiB |
| aa0b738 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
| dba2de8 | 23.75 KiB | 969.25 KiB | 945.50 KiB |
| 9be5373 | 23.75 KiB | 866.50 KiB | 842.75 KiB |
| ef2c9b3 | 23.75 KiB | 933.03 KiB | 909.29 KiB |
| 7bd90de | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 53b722c | 23.75 KiB | 906.08 KiB | 882.33 KiB |
| a6f5396 | 23.75 KiB | 989.12 KiB | 965.38 KiB |
| 62f8d2a | 23.75 KiB | 926.80 KiB | 903.05 KiB |
Previous results on branch: removeDeprecatedIntegrations
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b2ee5a | 1237.29 ms | 1265.98 ms | 28.69 ms |
| e207d9e | 1237.60 ms | 1271.82 ms | 34.21 ms |
| 75209a9 | 1217.91 ms | 1248.78 ms | 30.87 ms |
| ff29e12 | 1214.66 ms | 1248.91 ms | 34.25 ms |
| 08c8d7a | 1220.77 ms | 1260.15 ms | 39.38 ms |
| d35abd8 | 1219.20 ms | 1258.71 ms | 39.50 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b2ee5a | 23.75 KiB | 1.00 MiB | 1005.77 KiB |
| e207d9e | 23.75 KiB | 1.01 MiB | 1016.23 KiB |
| 75209a9 | 23.75 KiB | 1.00 MiB | 1005.77 KiB |
| ff29e12 | 23.75 KiB | 1.01 MiB | 1006.39 KiB |
| 08c8d7a | 23.75 KiB | 1.00 MiB | 1002.23 KiB |
| d35abd8 | 23.75 KiB | 1.01 MiB | 1008.62 KiB |
87033d4 to
310a2a6
Compare
Tests/SentryTests/Integrations/Performance/IO/DataSentryTracingIntegrationTests.swift
Outdated
Show resolved
Hide resolved
Tests/SentryTests/Integrations/Performance/IO/FileManagerTracingIntegrationTests.swift
Outdated
Show resolved
Hide resolved
Tests/SentryTests/Integrations/ViewHierarchy/SentryViewHierarchyIntegrationTests.swift
Show resolved
Hide resolved
310a2a6 to
85715ad
Compare
85715ad to
51eada2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
341c2cc to
3750705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the cleanup, left minor comments, but other than that LGTM
Tests/SentryTests/Integrations/Performance/CoreData/SentryCoreDataTrackingIntegrationTest.swift
Show resolved
Hide resolved
Tests/SentryTests/Integrations/Performance/IO/DataSentryTracingIntegrationTests.swift
Show resolved
Hide resolved
Tests/SentryTests/Integrations/Performance/IO/FileManagerTracingIntegrationTests.swift
Outdated
Show resolved
Hide resolved
3750705 to
7c0af00
Compare
df6c3dd to
59e2ffa
Compare
59e2ffa to
0e1f0ef
Compare
Remove this setting that is deprecated and removed in the v9 flag
#skip-changelog
Closes #6544