Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 9, 2025

Removes deprecated profiling options from SentryOptions. I wanted to remove these one at a time to make the PRs smaller, but turns out they are very closely related and trying to just remove some of them made it harder to understand the PR IMO.

Most of the change is in the tests. There were a lot of tests that tested the functionality of these options that are no longer relevant so I removed them.

#skip-changelog

Closes #6500

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.209%. Comparing base (fe83264) to head (808a3e8).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/Profiling/SentryLaunchProfiling.m 91.666% 1 Missing ⚠️
Sources/Sentry/SentryProfiler.mm 50.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6386       +/-   ##
=============================================
- Coverage   86.996%   86.209%   -0.788%     
=============================================
  Files          452       452               
  Lines        37691     37504      -187     
  Branches     17488     17402       -86     
=============================================
- Hits         32790     32332      -458     
- Misses        4854      5127      +273     
+ Partials        47        45        -2     
Files with missing lines Coverage Δ
...rces/Sentry/Profiling/SentryProfileConfiguration.m 89.285% <100.000%> (-0.370%) ⬇️
...entry/Profiling/SentryProfiledTracerConcurrency.mm 50.000% <100.000%> (-40.662%) ⬇️
...ces/Sentry/Profiling/SentryProfilingSwiftHelpers.m 96.875% <ø> (-0.095%) ⬇️
Sources/Sentry/SentryHub.m 96.625% <ø> (-0.042%) ⬇️
Sources/Sentry/SentryOptions.m 96.707% <ø> (-0.495%) ⬇️
Sources/Sentry/SentrySDKInternal.m 87.651% <ø> (+0.674%) ⬆️
Sources/Sentry/SentrySampling.m 91.836% <ø> (-2.684%) ⬇️
Sources/Sentry/SentrySpan.m 97.619% <ø> (-0.010%) ⬇️
Sources/Sentry/SentyOptionsInternal.m 99.646% <ø> (-0.025%) ⬇️
Sources/Sentry/Profiling/SentryLaunchProfiling.m 83.261% <91.666%> (+1.377%) ⬆️
... and 1 more

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe83264...808a3e8. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.98 ms 1252.87 ms 27.89 ms
Size 23.75 KiB 1.00 MiB 1004.44 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
bc4bb46 1235.63 ms 1264.24 ms 28.61 ms
cd9727b 1236.04 ms 1254.41 ms 18.37 ms
0759f32 1237.10 ms 1257.35 ms 20.25 ms
7aaa0b6 1230.49 ms 1263.78 ms 33.29 ms
c4b0360 1235.68 ms 1252.65 ms 16.97 ms
83e9b16 1223.25 ms 1250.94 ms 27.69 ms
18be519 1241.22 ms 1260.57 ms 19.35 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
1a820a1 1217.79 ms 1260.34 ms 42.55 ms
35c962f 1207.61 ms 1235.90 ms 28.29 ms

App size

Revision Plain With Sentry Diff
bc4bb46 23.75 KiB 980.81 KiB 957.07 KiB
cd9727b 23.75 KiB 879.25 KiB 855.51 KiB
0759f32 23.75 KiB 880.20 KiB 856.46 KiB
7aaa0b6 23.75 KiB 989.97 KiB 966.23 KiB
c4b0360 23.75 KiB 946.69 KiB 922.94 KiB
83e9b16 23.75 KiB 947.72 KiB 923.97 KiB
18be519 23.75 KiB 926.64 KiB 902.90 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
1a820a1 23.75 KiB 994.82 KiB 971.07 KiB
35c962f 23.75 KiB 854.77 KiB 831.02 KiB

Previous results on branch: removeDeprecatedProfiling

Startup times

Revision Plain With Sentry Diff
9c83d7c 1226.31 ms 1255.61 ms 29.30 ms
dfdec7c 1204.65 ms 1231.16 ms 26.52 ms
71bc84c 1221.04 ms 1261.89 ms 40.85 ms
5af5598 1229.83 ms 1254.36 ms 24.53 ms
e1027c9 1236.31 ms 1271.68 ms 35.37 ms
28fb90d 1216.85 ms 1250.10 ms 33.25 ms
f5e2a65 1217.68 ms 1248.96 ms 31.28 ms
d7174b5 1221.44 ms 1251.22 ms 29.79 ms

App size

Revision Plain With Sentry Diff
9c83d7c 23.75 KiB 987.76 KiB 964.01 KiB
dfdec7c 23.75 KiB 1.00 MiB 1004.69 KiB
71bc84c 23.75 KiB 1020.85 KiB 997.10 KiB
5af5598 23.75 KiB 1.00 MiB 1004.70 KiB
e1027c9 23.74 KiB 1021.80 KiB 998.05 KiB
28fb90d 23.75 KiB 1.00 MiB 1004.89 KiB
f5e2a65 23.75 KiB 1020.85 KiB 997.10 KiB
d7174b5 23.75 KiB 1020.85 KiB 997.10 KiB

@noahsmartin noahsmartin force-pushed the removeDeprecatedProfiling branch 14 times, most recently from 56f388a to 11bbfa6 Compare October 22, 2025 14:18
@noahsmartin noahsmartin force-pushed the removeDeprecatedProfiling branch from 11bbfa6 to 2ed0eac Compare October 22, 2025 15:05
cursor bot pushed a commit that referenced this pull request Oct 23, 2025
The workflow was creating duplicate issues when multiple trigger events
(opened, edited, synchronize, etc.) fired in quick succession. Both
workflow runs would check the PR simultaneously, find no issue reference,
and each create a new issue.

Added a check to search for existing issues created by this automation
before creating a new one. The workflow now searches for open issues that
contain the PR URL and were created by github-actions bot, preventing
duplicate issue creation.

Fixes the issue where PR #6386 had two issues created (#6499 and #6500).
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so great to see so much code go. Thanks @noahsmartin. One small comment and shouldn't we add a changelog entry for that? LGTM

SENTRY_LOG_DEBUG(@"Configuring continuous launch profile.");
configDict[kSentryLaunchProfileConfigKeyContinuousProfiling] = @YES;
# endif // !SDK_V9
if ([options isContinuousProfilingV2Enabled]) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: I guess we should rename isContinuousProfilingV2Enabled to isContinuousProfilingEnabled as the V2 now is the default, and we don't have a V1 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove profiling API deprecated in V9

2 participants