-
-
Couldn't load subscription status.
- Fork 369
chore: Remove debug meta decodable V9 checks #6379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6379 +/- ##
=============================================
+ Coverage 86.765% 86.854% +0.089%
=============================================
Files 438 439 +1
Lines 37311 37329 +18
Branches 17421 17411 -10
=============================================
+ Hits 32373 32422 +49
+ Misses 4893 4862 -31
Partials 45 45
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b714cb9 | 1224.71 ms | 1238.04 ms | 13.33 ms |
| d8b2303 | 1231.53 ms | 1249.89 ms | 18.35 ms |
| 59fc426 | 1240.49 ms | 1256.94 ms | 16.45 ms |
| cbbc82c | 1246.43 ms | 1266.13 ms | 19.70 ms |
| 7f4bf81 | 1241.73 ms | 1270.66 ms | 28.93 ms |
| 8203ac0 | 1235.59 ms | 1256.02 ms | 20.43 ms |
| c6c1cb7 | 1235.71 ms | 1263.80 ms | 28.08 ms |
| 7aaa0b6 | 1230.49 ms | 1263.78 ms | 33.29 ms |
| cc7f629 | 1226.00 ms | 1245.51 ms | 19.51 ms |
| c8dd5e4 | 1217.67 ms | 1242.90 ms | 25.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b714cb9 | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| d8b2303 | 23.75 KiB | 908.02 KiB | 884.27 KiB |
| 59fc426 | 23.75 KiB | 920.64 KiB | 896.89 KiB |
| cbbc82c | 23.75 KiB | 995.22 KiB | 971.47 KiB |
| 7f4bf81 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 8203ac0 | 23.75 KiB | 959.44 KiB | 935.69 KiB |
| c6c1cb7 | 23.75 KiB | 928.15 KiB | 904.40 KiB |
| 7aaa0b6 | 23.75 KiB | 989.97 KiB | 966.23 KiB |
| cc7f629 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
| c8dd5e4 | 23.75 KiB | 913.48 KiB | 889.72 KiB |
Previous results on branch: removeV9ChecksCodable
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d5671ca | 1232.93 ms | 1256.41 ms | 23.47 ms |
| b887253 | 1230.82 ms | 1268.76 ms | 37.93 ms |
| 75a96de | 1219.77 ms | 1247.24 ms | 27.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d5671ca | 23.75 KiB | 988.69 KiB | 964.94 KiB |
| b887253 | 23.75 KiB | 986.83 KiB | 963.08 KiB |
| 75a96de | 23.75 KiB | 986.88 KiB | 963.13 KiB |
9f14869 to
7587116
Compare
03cf114 to
fb46ceb
Compare
fb46ceb to
254c059
Compare
Removes one more v9 check for a codable class. Already added this to changelog in a previous PR that copied it from the V9 changelog.
#skip-changelog
Closes #6380