feat: Use S3 node store with garage #3498
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3498 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 3 3
Lines 207 207
=======================================
Hits 203 203
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
Any reason why you didn't use SeaweedFS per what you said yesterday? |
install/bootstrap-garage.sh
Outdated
|
|
||
| if [[ $($garage bucket list | tail -1 | awk '{print $1}') != 'nodestore' ]]; then | ||
| node_id=$($garage status | tail -1 | awk '{print $1}') | ||
| $garage layout assign -z dc1 -c 100G "$node_id" |
There was a problem hiding this comment.
Should this 100G be a variable somewhere?
There was a problem hiding this comment.
Yes, I think we should add a new GARAGE_STORAGE_SIZE env var to .env. That said not sure if that makes much sense as we would not honor any changes to that after the initial installation. Unless this actually reserves 100G, I think leaving it hard-coded to a "good enough" value and then documenting how to change this if needed would be a better option.
Thoughts?
There was a problem hiding this comment.
@aldy505 added the env var regardless. Do you think 100G is a good size for the average self-hosted operator?
There was a problem hiding this comment.
I don't know if 100G will be immediately allocated by Garage. If it's not (meaning the current storage space won't be modified) then I think it's good. If it's not, I think it's better to just allocate it to 25G space.
sentry/sentry.conf.example.py
Outdated
| SENTRY_NODESTORE = "sentry_nodestore_s3.S3PassthroughDjangoNodeStorage" | ||
| SENTRY_NODESTORE_OPTIONS = { | ||
| "delete_through": True, | ||
| "write_through": False, | ||
| "read_through": True, | ||
| "compression": False, # we have compression enabled in Garage itself | ||
| "endpoint_url": "http://garage:3900", | ||
| "bucket_path": "nodestore", | ||
| "bucket_name": "nodestore", | ||
| "retry_attempts": 3, | ||
| "region_name": "garage", | ||
| "aws_access_key_id": "<GARAGE_KEY_ID>", | ||
| "aws_secret_access_key": "<GARAGE_SECRET_KEY>", | ||
| } |
There was a problem hiding this comment.
(Docs) should we provide ways for the user to offload these to actual S3 or something?
There was a problem hiding this comment.
Maybe something under the "experimental" part?
There was a problem hiding this comment.
Probably would be better if we put it on the Experimental -> External Storage page. Will backlog that.
Co-authored-by: Reinaldy Rafli <[email protected]>
Well I started with that and realized 3 things:
Garage fits the bill much better as it is explicitly created for smaller setups like this, easy to expand without specialized roles, doesn't have any paid thing in it, and has much more decent and familiar S3 interface support. |
Enables S3 node store using Garage and sentry-nodestore-s3 by @stayallive
This should alleviate all the issues stemming from (ab)using PostgreSQL as the node store.