feat(inbound filters): Enable filtering sessions #4745
Draft
+219
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
commented
May 16, 2025
Comment on lines
+2026
to
+2027
| &self.inner.global_config.current(), | ||
| &config, |
There was a problem hiding this comment.
Here, we are getting passed the config from outside, but reading the global_config from self.inner. I did it this way because that's how it is in other processors (e.g. replays), but I don't know whether there's a good reason for it or it's a historical accident.
loewenheim
changed the title
Litarnus
reviewed
May 20, 2025
Comment on lines
+274
to
+291
| fn get_value(&self, path: &str) -> Option<relay_protocol::Val<'_>> { | ||
| let path = path.strip_prefix("session.")?; | ||
|
|
||
| match path { | ||
| "session_id" => Some(self.session_id.into()), | ||
| "distinct_id" => Some(self.distinct_id.as_deref()?.into()), | ||
| "sequence" => Some(self.sequence.into()), | ||
| "init" => Some(self.init.into()), | ||
| "duration" => Some(self.duration?.into()), | ||
| "errors" => Some(self.errors.into()), | ||
| "release" => Some(self.attributes.release.as_str().into()), | ||
| "environment" => Some(self.attributes.environment.as_deref()?.into()), | ||
| "ip_address" => Some(self.attributes.ip_address.as_ref()?.as_str().into()), | ||
| "user_agent" => Some(self.attributes.user_agent.as_deref()?.into()), | ||
| // TODO: status, abnormal mechanism? | ||
| _ => None, | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe it would make sense to only expose the same fields in SessionUpdate and SessionAggregates so that generic filters would work in a similar fashion for both things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables filtering for
SessionUpdateandSessionAggregateitems. In the course of this, it alsoFilterableandGetterimplementations toSessionUpdateandSessionAggregates;SessionProcessingConfigstruct to bundle all the auxiliary data needed inprocess_sessionandprocess_session_aggregates(modeled onReplayProcessingConfig);Aside from this not having tests, my main open questions are around the
Getterimpls. To wit:"session_update"/"session_aggregates")?Getterimpls change anything about the way filtering works? I believeFilterablealready returns the fields we actually care about.Closes RELAY-41.