ref: Rename relay-spans/span to otel_to_sentry #4742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for the spanv2 -> spanv1 and otel -> spanv2 conversions. It also introduces JSON snapshots into tests where appropriate.
loewenheim
commented
May 15, 2025
| @@ -629,126 +734,35 @@ mod tests { | |||
| }"#; | |||
|
|
|||
| let otel_span: OtelSpan = serde_json::from_str(json).unwrap(); | |||
| let span_from_otel = otel_to_sentry_span(otel_span).unwrap(); | |||
There was a problem hiding this comment.
This test already had a debug snapshot, the JSON one is just much more compact.
| @@ -884,5 +945,30 @@ mod tests { | |||
| get_path!(annotated_span.links[0].sampled), | |||
| Some(&Annotated::new(true)) | |||
| ); | |||
There was a problem hiding this comment.
All the tests already have explicit assertions that are technically redundant with the snapshots, but it's especially egregious with this one. Should we just remove these?
Dav1dde
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the spanv2 -> spanv1 and otel -> spanv2 conversions. It also introduces JSON snapshots into tests where appropriate.
ref: RELAY-63
#skip-changelog