ref(kafka): Make routing key optional, instead of randomizing it #4738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/optional-key-kafka
branch
from
0dcf936 to
7fea375
Compare
loewenheim
approved these changes
May 20, 2025
Comment on lines
78
to
+79
| /// Returns the partitioning key for this kafka message determining. | ||
| fn key(&self) -> [u8; 16]; | ||
| fn key(&self) -> Option<[u8; 16]>; |
There was a problem hiding this comment.
Unrelated to the change, but I don't understand what this docstring is trying to say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of randomly generating a routing key, we can just not set one in the first place.
From: https://stackoverflow.com/a/62211664
#skip-changelog