Skip to content

fix(evals): Restrict rubric judging to visible transcript#855

Merged
dcramer merged 1 commit into
mainfrom
codex/rubric-visible-transcript
Jul 12, 2026
Merged

fix(evals): Restrict rubric judging to visible transcript#855
dcramer merged 1 commit into
mainfrom
codex/rubric-visible-transcript

Conversation

@dcramer

@dcramer dcramer commented Jul 12, 2026

Copy link
Copy Markdown
Member

Slack eval rubrics now judge only the observed user/direct-assistant transcript text. The harness records inbound user messages and direct thread replies into the normalized eval session, while Slack API-captured side effects remain available for deterministic assertions but are excluded from the judge prompt.

The eval docs and policy now make the boundary explicit: use rubrics for semantic visible behavior, and use normal assertions for concrete side effects like tool calls, DB rows, reply counts, and artifacts. Existing core eval rubrics that mentioned reply counts, tool calls, reactions, channel posts, canvas artifacts, or Slack metadata were cleaned up to assert those boundaries deterministically instead.

@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
junior-docs Ready Ready Preview Jul 12, 2026 5:27pm

Request Review

Comment thread packages/junior-evals/src/helpers.ts
@dcramer dcramer force-pushed the codex/rubric-visible-transcript branch from a958b54 to b36e191 Compare July 12, 2026 17:03
@dcramer dcramer added the trigger-evals Run evals on a PR label Jul 12, 2026
@dcramer dcramer marked this pull request as ready for review July 12, 2026 17:03
@github-actions github-actions Bot added the risk: high PR risk score: high label Jul 12, 2026
Comment thread packages/junior-evals/evals/core/research-reply-shape.eval.ts Outdated
Comment thread packages/junior-evals/evals/core/slack-message-delivery.eval.ts
Comment thread packages/junior-evals/evals/core/lifecycle-and-resilience.eval.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 375a8a8. Configure here.

Comment thread packages/junior-evals/evals/core/routing-and-continuity.eval.ts
Record observed Slack user messages and direct assistant replies as the visible eval transcript, while keeping collected Slack side effects available for deterministic assertions outside the judge prompt.

Document the rubric boundary so semantic checks stay in rubrics and concrete side effects stay in assertions.

Co-Authored-By: GPT-5 Codex <codex@openai.com>
@dcramer dcramer force-pushed the codex/rubric-visible-transcript branch from 375a8a8 to 81ed341 Compare July 12, 2026 17:26
@dcramer dcramer merged commit 2750acf into main Jul 12, 2026
33 checks passed
@dcramer dcramer deleted the codex/rubric-visible-transcript branch July 12, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high PR risk score: high trigger-evals Run evals on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant