Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

fix(cloudbuild): path for log files was constructed incorrectly #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cloudbuild): path for log files was constructed incorrectly #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion freight/checks/cloudbuilder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def check(self, app, sha, config):
}

if build_status == "FAILURE":
build_logtext = u"https://storage.googleapis.com/{}/log-{}.txt".format(
build_logtext = u"https://storage.googleapis.com/{}log-{}.txt".format(
build_logs[5:], build_id
)
log = http.get(build_logtext, headers=headers)
Expand Down
2 changes: 1 addition & 1 deletion tests/checks/test_cloudbuilder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def test_build_fail(self):
responses.add(
responses.GET,
u"https://storage.googleapis.com/{build_logs}/log-{build_id}.txt".format(
build_logs="mycoolproject.cloudbuild-logs.googleusercontent.com",
build_logs="mycoolbucket/mycoolproject/",
build_id="failed_build_id",
),
body=dedent(failed_log_text),
Expand Down