ref(cli): Centralize skill symlink targets#128
Merged
Conversation
Move repeated scope, agent, and legacy target enumeration into a shared pure projection. Keep creation, repair, reporting, and output policy in their commands while preserving ordering, exact-string deduplication, and native skill readers. Verify sync repairs the projected legacy path and cover project and user scope semantics. Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize the skill-symlink targets used by install, sync, doctor, and init into one scope-aware projection.
These commands independently accumulated the same legacy-target, configured-agent, user-scope, and deduplication logic after user-scope support was added. Keeping target selection in one pure function prevents the commands from disagreeing while leaving creation, repair, reporting, and output behavior with the command that owns it.
The projection preserves legacy-first ordering, exact-string compatibility, user-scope target rules, and agents that read
.agents/skillsnatively. Sync now repairs the same absolute legacy target it verifies instead of projecting that target a second time.Regression coverage includes project and user targets, duplicate Claude/Cursor paths, native readers, relative scope roots, legacy-looking absolute paths, doctor reporting, and the repaired filesystem link.