fix(utils): Prevent RangeError from large command output #433
1 issue
code-review: Found 1 issue (1 medium)
Medium
No test coverage for new output truncation and buffer accumulation logic - `src/utils/command.ts:78`
The new appendChunk, finalizeStream, and maxOutputBytes logic — including XCODEBUILDMCP_MAX_OUTPUT_BYTES env parsing — has no unit tests in src/utils/__tests__/command.test.ts, leaving the critical crash-prevention path unverified.
Also found at:
src/utils/command.ts:229
⏱ 5m 49s · 335.6k in / 17.6k out · $0.85
Annotations
Check warning on line 78 in src/utils/command.ts
sentry-warden / warden: code-review
No test coverage for new output truncation and buffer accumulation logic
The new `appendChunk`, `finalizeStream`, and `maxOutputBytes` logic — including `XCODEBUILDMCP_MAX_OUTPUT_BYTES` env parsing — has no unit tests in `src/utils/__tests__/command.test.ts`, leaving the critical crash-prevention path unverified.
Check warning on line 229 in src/utils/command.ts
sentry-warden / warden: code-review
[JDM-NLA] No test coverage for new output truncation and buffer accumulation logic (additional location)
The new `appendChunk`, `finalizeStream`, and `maxOutputBytes` logic — including `XCODEBUILDMCP_MAX_OUTPUT_BYTES` env parsing — has no unit tests in `src/utils/__tests__/command.test.ts`, leaving the critical crash-prevention path unverified.