feat(ui-automation): Add rs/1 runtime automation parity - #416
2 issues
xcodebuildmcp-test-boundary-review: Found 2 issues (1 medium, 1 low)
Medium
type-text success-path snapshot contract removed with no replacement - `src/snapshot-tests/suites/ui-automation-suite.ts:263-286`
The type-text--success snapshot fixture was deleted and the success case in the snapshot suite replaced entirely with two error-path tests, leaving no e2e contract snapshot for the happy path.
Low
Screenshot test reimplements `createCommandMatchingMockExecutor` inline - `src/mcp/tools/ui-automation/__tests__/screenshot.test.ts:18-50`
src/mcp/tools/ui-automation/__tests__/screenshot.test.ts introduces a new inline createBootedScreenshotMockExecutor factory that branches on command string and returns a preset response per branch. The shared helper createCommandMatchingMockExecutor in src/test-utils/mock-executors.ts is explicitly documented for this exact multi-command pattern (simctl list + screenshot capture) and already provides the routing, default success, and mock process plumbing. Using the shared helper preserves the 'Use existing mock executor helpers' guardrail and keeps unexpected-command diagnostics consistent across tests.
⏱ 31m 55s · 4.7M in / 210.0k out · $8.20
Annotations
Check warning on line 286 in src/snapshot-tests/suites/ui-automation-suite.ts
sentry-warden / warden: xcodebuildmcp-test-boundary-review
type-text success-path snapshot contract removed with no replacement
The `type-text--success` snapshot fixture was deleted and the success case in the snapshot suite replaced entirely with two error-path tests, leaving no e2e contract snapshot for the happy path.