Skip to content

Fix shell injection vulnerability in release workflow (ENG-6554) #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameroncooke merged 4 commits into from
Feb 21, 2026
Merged

Fix shell injection vulnerability in release workflow (ENG-6554) #229

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d067806
Fix shell injection vulnerability in release workflow
fix-it-felix-sentry[bot] Feb 18, 2026
8aae9b6
Merge branch 'main' into fix/eng-6554-shell-injection-vulnerability
cameroncooke Feb 21, 2026
8001d9c
fix(release): harden workflow version handling and shell interpolation
cameroncooke Feb 21, 2026
a4c6513
fix(release): allow semver prerelease tags without numeric suffix
cameroncooke Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,17 @@ jobs:

- name: Get version from tag or input
id: get_version
env:
GH_EVENT_NAME: ${{ github.event_name }}
GH_INPUT_VERSION: ${{ github.event.inputs.version }}
run: |
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
VERSION="${{ github.event.inputs.version }}"
if [ "$GH_EVENT_NAME" = "workflow_dispatch" ]; then
VERSION="$GH_INPUT_VERSION"
Comment thread
cursor[bot] marked this conversation as resolved.
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
echo "IS_TEST=true" >> $GITHUB_OUTPUT
echo "📝 Test version: $VERSION"
# Update package.json version for test releases only
npm version $VERSION --no-git-tag-version
npm version "$VERSION" --no-git-tag-version
else
VERSION=${GITHUB_REF#refs/tags/v}
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
Expand Down
Loading