-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Reflectable
package for reference docs
#2415
base: release/v5
Are you sure you want to change the base?
Conversation
As I wrote on Discord, I really like the new structure and modularity. Quick note before I forget: This could also enable #2264 more easily, right? Could well be a different PR though as we need to update the tags in the core code anyway before it will be visible in the reference. |
Yes, I even tried to add it quickly but then ran into a huge loading time. But that was because I wanted to filter them already in the But yes, probably better as a second step when we replace most |
In production we could probably use a collection cache for this. I think with filtering we need it anyway, otherwise the overview pages will be incredibly slow. |
A bug I noticed in the rewrite: In Edit: Not a new bug, it already happens on getkirby.com |
A fatal error I found on
|
That's the bug in the v5 beta not allowing for virtual content when a content folder foes exist. |
I've started to collect the issues in the first post to keep an overview of what is already fixed. |
This lost camel-casing is not new. Maybe we can split the todos in regressions and nice-to-have enhancements. (I just saw you already have that, so maybe just moving that to the second section). |
Oh, didn't realize that, normally I check but here I forgot. Will create a separate issue. |
Description
Summary of changes
Kirby\Reference\Reflectable
packageReturns
,Deprecated
etc.)Kirby\Reference\Types
package@internal
marked are now still included in the reference, but a warning is displayed on the detail pageReasoning
Our code in the page models and one types class was getting overwhelmingly complex. Copping it up in dedicated classes makes it a lot easier to work with.
Todos
Bugs
$kirby
/$app
variables being mixed up$request
) in menuOptional enhancements
required-mark
asterisk #2419