Resend a now invalid invite is no 500 internal server error#322
Open
Xaratas wants to merge 1 commit intogetgrav:developfrom
Open
Resend a now invalid invite is no 500 internal server error#322Xaratas wants to merge 1 commit intogetgrav:developfrom
Xaratas wants to merge 1 commit intogetgrav:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: I you try to use an invite twice, for example by a double click heavy user or by refreshing the page and approve the form resubmit you hit the RuntimeException in processUserRegistration.
But this is no 500 internal server error case. The actual invite was already successfully handled at this point and thus removed from the invites file. Also throwing a „you broke stuff“ error at the user is not helpful for improving confidence in your invite process.
It is changed to a simple error message that displays an (understandable) reason why something failed.
Redirecting to the frontpage is a bit of a question. But you where on the closed register page with an invite, that you can no longer use (because it was used and deleted) to access that page. So the frontpage was the next best option.
Also minor change to give the 2 password fields unique html ids.