Properly validate select fields

getformwork · Feb 28, 2025 · d9f0c1f · d9f0c1f
1 parent aa3e9c6
commit d9f0c1f
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/formwork/fields/select.php b/formwork/fields/select.php
@@ -1,8 +1,10 @@
 <?php
 
 use Formwork\Cms\App;
+use Formwork\Fields\Exceptions\ValidationException;
 use Formwork\Fields\Field;
 use Formwork\Utils\Arr;
+use Formwork\Utils\Constraint;
 
 return function (App $app) {
     return [
@@ -11,6 +13,14 @@
         },
 
         'validate' => function (Field $field, $value) {
+            if (Constraint::isEmpty($value)) {
+                return '';
+            }
+
+            if (!array_key_exists($value, $field->options())) {
+                throw new ValidationException(sprintf('Invalid value for field "%s" of type "%s"', $field->name(), $field->type()));
+            }
+
             if (is_numeric($value)) {
                 // This reliably casts numeric values to int or float
                 return $value + 0;