Skip to content

Conversation

@teodorciuraru
Copy link
Contributor

@teodorciuraru teodorciuraru commented Oct 22, 2025

Summary

  • Updates Flutter quickstart Android NDK version from flutter.ndkVersion (26.x) to "27.0.12077973"
  • Fixes build failure caused by NDK version mismatch with Ditto SDK 4.12.3

Details

The ditto_live Flutter plugin 4.12.3 and its dependencies require Android NDK 27.0.12077973, but the Flutter Gradle plugin provides NDK 26.x by default. This causes build failures with the error:

Your project is configured with **Android NDK 26.3.11579264**, but the following plugin(s) depend on a different Android NDK version:
- ditto_live requires Android NDK 27.0.12077973
- path_provider_android requires Android NDK 27.0.12077973
- permission_handler_android requires Android NDK 27.0.12077973

This PR explicitly sets the NDK version to 27.0.12077973 in the android block of flutter_app/android/app/build.gradle, which is the recommended fix according to the Gradle error message. NDK versions are backward compatible.

Test plan

  • Built and ran the Flutter quickstart app on Android emulator successfully
  • Verified app launches and loads without NDK-related errors
  • Confirmed Ditto SDK 4.12.3 artifacts download correctly

🤖 Generated with Claude Code

Updates the Flutter quickstart Android NDK version from flutter.ndkVersion (26.x) to 27.0.12077973 to match the requirement of ditto_live 4.12.3 and its plugin dependencies.

This fixes the build failure:
- ditto_live requires Android NDK 27.0.12077973
- path_provider_android requires Android NDK 27.0.12077973
- permission_handler_android requires Android NDK 27.0.12077973

NDK versions are backward compatible, so using 27.x is safe.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copilot AI review requested due to automatic review settings October 22, 2025 15:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an Android build failure in the Flutter quickstart by updating the NDK version to match the requirements of the Ditto SDK 4.12.3 and its dependencies.

Key Changes:

  • Updates Android NDK version from Flutter's default (26.x) to the explicitly required version 27.0.12077973
  • Resolves build failures caused by NDK version mismatch between the Flutter Gradle plugin and Ditto SDK dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@teodorciuraru teodorciuraru marked this pull request as draft October 22, 2025 16:16
@teodorciuraru teodorciuraru self-assigned this Oct 22, 2025
@teodorciuraru
Copy link
Contributor Author

teodorciuraru commented Oct 22, 2025

@phatblat, also reaching out for your review here. Is this PR on point? Do our Android artifacts enforce Android NDK 27 starting 4.12.3?

@teodorciuraru teodorciuraru force-pushed the fix/flutter-android-ndk-version branch from b13882c to 4f49349 Compare October 23, 2025 13:17
Copy link
Contributor

@pvditto pvditto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-request when ready for review!

@teodorciuraru
Copy link
Contributor Author

After consulting with @phatblat, it seems like we already want to bump dependencies to NDK 27.0. I couldn't find a better way to make the QS for Flutter build, except for this fix. Marking it Ready for Review.

@teodorciuraru teodorciuraru marked this pull request as ready for review October 27, 2025 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@pvditto pvditto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version was set using a variable to centralize versions used in a single place and have a place to document anything important that maintainers need to know about them. Let's keep with that pattern. If we need two different ndk versions, let's set two different variables and document why they need to diverge. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants