-
Couldn't load subscription status.
- Fork 6
fix(flutter): update Android NDK version to 27.0.12077973 #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updates the Flutter quickstart Android NDK version from flutter.ndkVersion (26.x) to 27.0.12077973 to match the requirement of ditto_live 4.12.3 and its plugin dependencies. This fixes the build failure: - ditto_live requires Android NDK 27.0.12077973 - path_provider_android requires Android NDK 27.0.12077973 - permission_handler_android requires Android NDK 27.0.12077973 NDK versions are backward compatible, so using 27.x is safe. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an Android build failure in the Flutter quickstart by updating the NDK version to match the requirements of the Ditto SDK 4.12.3 and its dependencies.
Key Changes:
- Updates Android NDK version from Flutter's default (26.x) to the explicitly required version 27.0.12077973
- Resolves build failures caused by NDK version mismatch between the Flutter Gradle plugin and Ditto SDK dependencies
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@phatblat, also reaching out for your review here. Is this PR on point? Do our Android artifacts enforce Android NDK 27 starting 4.12.3? |
b13882c to
4f49349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-request when ready for review!
|
After consulting with @phatblat, it seems like we already want to bump dependencies to NDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version was set using a variable to centralize versions used in a single place and have a place to document anything important that maintainers need to know about them. Let's keep with that pattern. If we need two different ndk versions, let's set two different variables and document why they need to diverge. WDYT?
Summary
flutter.ndkVersion(26.x) to"27.0.12077973"Details
The ditto_live Flutter plugin 4.12.3 and its dependencies require Android NDK 27.0.12077973, but the Flutter Gradle plugin provides NDK 26.x by default. This causes build failures with the error:
This PR explicitly sets the NDK version to 27.0.12077973 in the android block of
flutter_app/android/app/build.gradle, which is the recommended fix according to the Gradle error message. NDK versions are backward compatible.Test plan
🤖 Generated with Claude Code