Skip to content

Show all tasks in big-plan Kanban view regardless of actionable date #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
horia141 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Show all tasks in big-plan Kanban view regardless of actionable date #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/jupiter/core/common/sub/inbox_tasks/components/kanban-board.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export interface InboxTaskKanbanBoardProps {
optimisticUpdates: { [key: string]: InboxTaskOptimisticState };
inboxTasksByRefId: { [key: string]: InboxTask };
moreInfoByRefId: { [key: string]: InboxTaskParent };
actionableTime: ActionableTime;
actionableTime?: ActionableTime;
allowEisen?: Eisen;
groupId?: string;
draggedInboxTaskId?: string;
Expand Down Expand Up @@ -169,7 +169,7 @@ interface InboxTasksColumnProps {
inboxTasksByRefId: { [key: string]: InboxTask };
optimisticUpdates: { [key: string]: InboxTaskOptimisticState };
moreInfoByRefId: { [key: string]: InboxTaskParent };
actionableTime: ActionableTime;
actionableTime?: ActionableTime;
collapsed?: boolean;
allowStatus: InboxTaskStatus;
allowEisen?: Eisen;
Expand Down
2 changes: 1 addition & 1 deletion src/core/jupiter/core/common/sub/inbox_tasks/components/small-screen-kanban.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ interface SmallScreenKanbanBaseProps {
optimisticUpdates: { [key: string]: InboxTaskOptimisticState };
moreInfoByRefId: { [key: string]: InboxTaskParent };
allowEisen?: Eisen;
actionableTime: ActionableTime;
actionableTime?: ActionableTime;
onCardMarkDone?: (it: InboxTask) => void;
onCardMarkNotDone?: (it: InboxTask) => void;
emptyParent: string;
Expand Down
7 changes: 5 additions & 2 deletions src/core/jupiter/core/infra/actionable-time.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@ export enum ActionableTime {
}

export function actionableTimeToDateTime(
actionableTime: ActionableTime,
actionableTime: ActionableTime | undefined,
timezone: Timezone,
): DateTime {
): DateTime | undefined {
if (actionableTime === undefined) {
return undefined;
}
switch (actionableTime) {
case ActionableTime.NOW:
return DateTime.local({ zone: timezone });
Expand Down
5 changes: 0 additions & 5 deletions src/webui/app/routes/app/workspace/big-plans/$id.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ import {
SmallScreenKanbanByEisen,
} from "@jupiter/core/common/sub/inbox_tasks/components/small-screen-kanban";
import { StandardDivider } from "@jupiter/core/infra/component/standard-divider";
import { ActionableTime } from "@jupiter/core/infra/actionable-time";
import { useBigScreen } from "@jupiter/core/infra/component/use-big-screen";
import {
isInboxTaskCoreFieldEditable,
Expand Down Expand Up @@ -720,7 +719,6 @@ export default function BigPlan() {
optimisticUpdates={optimisticUpdates}
inboxTasksByRefId={inboxTasksByRefId}
moreInfoByRefId={{}}
actionableTime={ActionableTime.NOW}
allowEisen={e}
draggedInboxTaskId={draggedInboxTaskId}
cardLinkResolver={(it) =>
Expand All @@ -738,7 +736,6 @@ export default function BigPlan() {
inboxTasks={sortedInboxTasks}
optimisticUpdates={optimisticUpdates}
moreInfoByRefId={{}}
actionableTime={ActionableTime.NOW}
onCardMarkDone={handleCardMarkDone}
onCardMarkNotDone={handleCardMarkNotDone}
emptyParent="inbox task"
Expand All @@ -763,7 +760,6 @@ export default function BigPlan() {
optimisticUpdates={optimisticUpdates}
inboxTasksByRefId={inboxTasksByRefId}
moreInfoByRefId={{}}
actionableTime={ActionableTime.NOW}
draggedInboxTaskId={draggedInboxTaskId}
cardLinkResolver={(it) =>
`/app/workspace/big-plans/${loaderData.bigPlan.ref_id}/inbox-tasks/${it.ref_id}`
Expand All @@ -777,7 +773,6 @@ export default function BigPlan() {
inboxTasks={sortedInboxTasks}
optimisticUpdates={optimisticUpdates}
moreInfoByRefId={{}}
actionableTime={ActionableTime.NOW}
onCardMarkDone={handleCardMarkDone}
onCardMarkNotDone={handleCardMarkNotDone}
emptyParent="inbox task"
Expand Down