Change layer_on to layer_move #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
force-pushed
the
georgi
branch
2 times, most recently
from
6441a67 to
ca812f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think layer_move makes more sense here, because the layer 1 overrides layer 0 completely anyway.
(and it prevents some annoying debugging-time if someone decide to move layer GAMING to a smaller index than layer STENO_LAYER)
Note. (the issues tab is not open? And) I'm not sure which branch to push to.
Also on that note, I'd like to move the macro definitions to some header file and use from that header file too (but that might potentially be disruptive), hard coding
1there isn't a good idea.... in retrospect, it might be better to just add
layer_move(GAMING)to the startup script to make that layer the default from the beginning. Had some unrelated issues with EEPROM andset_single_persistent_default_layer.