[GEOS-12019] Turn arcgrid and worldimage formats into plugins #394

MikhailLukyaniuk · 2025-12-17T09:37:05Z

Checklist

I have read the contribution guidelines.
I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
First PR targets the main branch (backports managed later; ignore for branch specific issues).

For core and extension modules:

New unit tests have been added covering the changes.
Documentation has been updated (if change is visible to end users).
The REST API docs have been updated (when changing configuration objects or the REST controllers).
There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
Bug fixes and small new features are presented as a single commit.
Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

The PR will be merged when all the build checks are green (see automated QA checks), there is a code committer review, and the checklist has been fulfilled.

aaime · 2025-12-17T09:47:08Z

@MikhailLukyaniuk please have a look at the build failures, they look legit. Ping me back when the github actions are green (or they are failing, but you think it's unrelated to your changes).

MikhailLukyaniuk · 2025-12-17T10:38:04Z

@MikhailLukyaniuk please have a look at the build failures, they look legit. Ping me back when the github actions are green (or they are failing, but you think it's unrelated to your changes).

@aaime sure, I also have question, while testing i see that images and arcgrid jars still present in target/release/geoserver-3.0-SNAPSHOT-bin/webapps/geoserver/WEB-INF/lib and some other modules still depends on them, like web-core depends on arcgrid and removing dependency causing error

2025-12-17 10:19:51.881:WARN :oeje11w.WebAppContext:main: Failed startup of context oeje11w.WebAppContext@293bb8a5{GeoServer,/geoserver,b=file:///Users/mikhaillukyaniuk/IdeaProjects/geoserver/src/target/release/geoserver-3.0-SNAPSHOT-bin/webapps/geoserver/,a=AVAILABLE,h=oeje11s.SessionHandler@2416a51{STARTED}}
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'arcGridStorePanel' defined in URL [jar:file:/Users/mikhaillukyaniuk/IdeaProjects/geoserver/src/target/release/geoserver-3.0-SNAPSHOT-bin/webapps/geoserver/WEB-INF/lib/gs-web-core-3.0-SNAPSHOT.jar!/applicationContext.xml]: Failed to convert property value of type 'java.lang.String' to required type 'java.lang.Class' for property 'factoryClass'; Could not find class [org.geotools.gce.arcgrid.ArcGridFormat]

so not clear a little, how I should handle this?

aaime

Overall looks good, see notes below.

aaime · 2025-12-19T09:06:07Z

doc/en/user/source/extensions/arcgrid/index.rst

@@ -0,0 +1,52 @@
+.. _arcgrid_extension:
+
+Installing the ArcGrid extension


Good, but the data/arcgrid page was not updated to mention it is an extension.

See the image pyramid format page for an example of how that's done.

In addition, the arcgrid format is mentioned in other places:

Store example, switch to GeoTIFF (you can use the same store from the release data directory, as now it is a GeoTIFF) and update the screenshot.

The layer preview page mentions it, please switch it and update the screenshot

The ncwms page also mentions the format of the layer as arcgrid, switch to GeoTIFF as needed

These instances have been found running git grep -i arcgrid in the doc/en/user documentation folder (there are a few others but they don't seem problematic)

aaime · 2025-12-19T09:06:41Z

doc/en/user/source/extensions/image/index.rst

@@ -0,0 +1,52 @@
+.. _image_extension:
+
+Installing the Image extension


Same as with the arcgrid extension, please ensure the worldimage format page mentions it is an extension.

In addition the getting started documentation suggests to use the worldimage format for the Natural Earth shaded relief. While the zip still contains all files, using the tif alone is sufficient, that's a GeoTIFF. So please update the tutorial accordingly.

aaime · 2025-12-19T09:26:13Z

src/extension/arcgrid/src/test/java/org/geoserver/arcgrid/ModuleStatusTest.java

@@ -0,0 +1,31 @@
+package org.geoserver.arcgrid;


Missing copyright header (use 2025 as the year)

aaime · 2025-12-19T09:26:21Z

src/extension/arcgrid/src/main/resources/applicationContext.xml

@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- 
+ Copyright (C) 2021 - Open Source Geospatial Foundation. All rights reserved.


2025 please

aaime · 2025-12-19T09:26:29Z

src/extension/image/src/main/resources/applicationContext.xml

@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- 
+ Copyright (C) 2021 - Open Source Geospatial Foundation. All rights reserved.


aaime · 2025-12-19T09:26:36Z

src/extension/image/src/test/java/org/geoserver/image/ModuleStatusTest.java

@@ -0,0 +1,31 @@
+package org.geoserver.image;


Missing copyright header

aaime · 2025-12-19T09:26:42Z

src/extension/image/pom.xml

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- 
+ Copyright (C) 2014 - Open Source Geospatial Foundation. All rights reserved.


MikhailLukyaniuk requested a review from aaime December 17, 2025 09:37

MikhailLukyaniuk self-assigned this Dec 17, 2025

MikhailLukyaniuk force-pushed the GEOS-12019-turn-arcgrid-and-worldimage-formats-into-plugins branch from 21d161c to 2d5a471 Compare December 17, 2025 09:48

MikhailLukyaniuk force-pushed the GEOS-12019-turn-arcgrid-and-worldimage-formats-into-plugins branch 7 times, most recently from 38e555e to d00efae Compare December 18, 2025 13:46

aaime requested changes Dec 19, 2025

View reviewed changes

[GEOS-12019] Turn arcgrid and worldimage formats into plugins

134a925

MikhailLukyaniuk force-pushed the GEOS-12019-turn-arcgrid-and-worldimage-formats-into-plugins branch from d00efae to 134a925 Compare December 19, 2025 16:26

MikhailLukyaniuk requested a review from aaime December 19, 2025 16:26

MikhailLukyaniuk closed this Dec 19, 2025

		@@ -0,0 +1,52 @@
		.. _arcgrid_extension:

		Installing the ArcGrid extension

		@@ -0,0 +1,52 @@
		.. _image_extension:

		Installing the Image extension

[GEOS-12019] Turn arcgrid and worldimage formats into plugins #394

[GEOS-12019] Turn arcgrid and worldimage formats into plugins #394

Uh oh!

Conversation

MikhailLukyaniuk commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

aaime commented Dec 17, 2025

Uh oh!

MikhailLukyaniuk commented Dec 17, 2025

Uh oh!

aaime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MikhailLukyaniuk commented Dec 17, 2025 •

edited

Loading