Update primary field argument passed to ElectrostaticSphere#578
Open
santisoler wants to merge 2 commits intomainfrom
Open
Update primary field argument passed to ElectrostaticSphere#578santisoler wants to merge 2 commits intomainfrom
santisoler wants to merge 2 commits intomainfrom
Conversation
Use an array with 3 elements instead of a float as the `primary_field` argument for the `ElectrostaticSphere`. Geoana errors out if a float is passed instead.
Member
Author
|
@lheagy I think this solves the error that Geoana raises. Please, check that the values for the primary field are correct. |
Member
|
Thanks Santi! It looks like this now runs, but the results for the electric field and the current density look off e.g. currently on the site and now This might be a bug down in geoana. The potentials look correct though |
Member
|
I was hoping this would be obvious, but it will take some more time to figure out where things went sideways here. What do you think of pinning to an older version of geoana for now so that we can get #577 in, @santisoler? |
Member
Author
|
Sure! Let's pin it. We can solve this later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an array with 3 elements instead of a float as the
primary_fieldargument for theElectrostaticSphere. Geoana errors out if a float is passed instead.