Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP tweaks #150
base: nav-health
Are you sure you want to change the base?
WIP tweaks #150
Changes from 1 commit
8d83418
858d515
0663a56
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might also want to add reference to the Galileo and QZSS ICDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes definitely, this is work in progress, QZSS was the first dedicated specs I looked into, that's why it's there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed all
Sv
toSV
as SV is an acronym for Satellite VehicleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In RINEX v3 and v4 the Galileo health definition is the same for both INAV and FNAV
Though there is another field "data source" that indicates as well if INAV or FNAV (mainly for v3)
For INAV only bits for E1B and E5b can be set (since E5a not transmitted in INAV).
For FNAV only bits for E5a can be set (since E1B & E5b not transmitted in FNAV).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to a struct (with to/from
u32
conversions) as HS is actually a 2 bit integer and not two separate bit flagsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, all the NAV ecosystem implements the
UpperExp
formatting because that's how we (intend) to format those fields in file production contexts.I say intend because NAV files production is the most problematic still to this day, while OBS and Meteo RINEX have been completed already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the names of the structs similar to the enum cases is less confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the Galileo struct, I also made this a struct as the lower 5 bits are actually a 5 bit integer
To tell health of just L1 or L2 some complex switch would be needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
easier to grasp ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPS has same definition of health bits in CNAV and CNAV-2 so I changed this to a single struct used in both enum cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed from
L1Healthy
to justL1
as Healthy makes it sound liketrue
= healthy when the definition is actually the opposite