-
Notifications
You must be signed in to change notification settings - Fork 228
Covers base #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Covers base #1433
Conversation
|
Bench Big leap over |
add876d to
7bda9fd
Compare
|
Is there a reason that this is a draft? I haven't looked at it closely yet, but directionally it makes sense. Sorry again for the slow review cycle. I appreciate the new functionality and speedups! I've been busy elsewhere, but trying to steadily get through these geo PRs. |
|
A few reasons
I probably could clean this up and add tests for the non relate and intersects-derived parts, |
7bda9fd to
7badffc
Compare
|
Ok, no rush! I just wanted to be sure you weren't waiting on the repository maintainers for something. |
3aae4e0 to
a1071b6
Compare
|
Added tests for the non-derived linestring functions to ensure they're correctly different with the contains functions |
|
Please add an entry for this somewhere in the Lines 45 to 187 in 87b70cc
|
|
@cookiedan42 Please squash your commits! |
5f2b8cb to
760d908
Compare
CHANGES.mdif knowledge of this change could be valuable to users.Simplification of
Containsin the opposite direction of #1427 ,Coverstrait allows for simpler Geom in Geom operations because we don't need to be concerned about rhs being inside self's boundaryParts implemented
CoversTraitRelateintersectsContainsCoverslacking in the test department, but these are the basic derivable implementations