Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't borrow epsilon in the Simplify* traits #1340

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

urschrei
Copy link
Member

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Fixes #1339

@urschrei urschrei force-pushed the shugel/push-vxozytolmnus branch from b505ec8 to e13ad8a Compare March 31, 2025 23:11
@urschrei urschrei requested a review from michaelkirk March 31, 2025 23:12
Copy link
Contributor

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple refactor to me. I dunno if there are any special steps to making breaking API changes, besides the note in the changelog?

@urschrei
Copy link
Member Author

urschrei commented Apr 1, 2025

…to which I should add a "BREAKING" annotation. But generally no, we don't do anything else.

@urschrei urschrei force-pushed the shugel/push-vxozytolmnus branch from e13ad8a to 591e33c Compare April 1, 2025 10:46
@michaelkirk michaelkirk added this pull request to the merge queue Apr 8, 2025
Merged via the queue into georust:main with commit 750ed14 Apr 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API ergonomics: Simplify should take an owned, not borrowed float:
3 participants