Implement intersection and From trait on Rect #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
requested changes
Mar 29, 2025
There was a problem hiding this comment.
Hello @mfbehrens - I don't recognize your handle, so welcome to georust!
Especially since you're new, I'd recommend starting with a discussion or issue before opening PRs.
If you're not already there, consider joining us in discord: https://discord.gg/Fp2aape
As for this PR, I think this behavior is likely to be useful to geo users, but based on how these libraries are organized, this functionality would be a better fit in geo, not geo-types, and it should be based on a trait, so that it could potentially implemented on other geometric primitives (triangle, polygon, etc.) as well.
|
🤦 I see you did open an issue (#1323), and I never responded. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Fix #1323