Empty geoms have equal topo #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, this is a divergence from JTS.Geometry.isEqualTopo, but it seems like the right thing to do. Supportive discussion with Dr. JTS: locationtech/jts#1087 (comment) It also aligns with the new Overlay semantics in GEOS (OverlayNG).
michaelkirk
force-pushed
the
mkirk/fix-equal-top-for-empty
branch
from
962f59a to
1748fcf
Compare
kylebarron
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Note, this is a divergence from JTS.Geometry.isEqualTopo, but it seems
like the right thing to do.
Supportive discussion with Dr. JTS:
locationtech/jts#1087 (comment)
It also aligns with the new Overlay semantics in GEOS (OverlayNG).