Skip to content

Conversation

@cehbrecht
Copy link
Collaborator

Overview

This PR fixes the file storage. Output files were not saved to storage after introducing PR #451.

Related Issue / Discussion

#451

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@cehbrecht cehbrecht added the bug label Dec 6, 2019
@cehbrecht cehbrecht added this to the 4.4.0 milestone Dec 6, 2019
@cehbrecht cehbrecht requested a review from jachym December 6, 2019 19:38
@cehbrecht
Copy link
Collaborator Author

@roarmstrong @davidcaron @huard Please have a look it this PR. File storage currently does not work on master ... didn't notice before. I was using the latest release of pywps in emu.

@davidcaron
Copy link
Contributor

I ran into the same issue a couple hours ago 🙂
I came into the same conclusion as you did, I think this will fix it.

@huard
Copy link
Collaborator

huard commented Dec 6, 2019

Not familiar with this part of the code.

@roarmstrong
Copy link
Contributor

Fix looks good to me, apologies I didn't catch this in the original PR!

@jachym
Copy link
Member

jachym commented Dec 9, 2019

if I reed this correctly, travis is complaining about the code style?

otherwise it can be merged IMHO, thank you

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 75.161% when pulling fa519ec on cehbrecht:fix-file-storage into a0ff367 on geopython:master.

@cehbrecht cehbrecht merged commit 9709866 into geopython:master Dec 9, 2019
@cehbrecht cehbrecht deleted the fix-file-storage branch December 9, 2019 10:18
@cehbrecht
Copy link
Collaborator Author

@davidcaron @huard @roarmstrong @jachym merged. Thanks for your quick response and review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants