Skip to content

Conversation

@cehbrecht
Copy link
Collaborator

Overview

This is an update of PR #451. If fixes the async keyword and the usage of the new FileStorageBuilder.

Related Issue / Discussion

Fix #502

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • [ x] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • [ x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@cehbrecht cehbrecht added the bug label Nov 13, 2019
@cehbrecht cehbrecht added this to the 4.4.0 milestone Nov 13, 2019
@cehbrecht cehbrecht requested a review from jachym November 13, 2019 14:08
@cehbrecht
Copy link
Collaborator Author

@davidcaron @tomkralidis ok to merge to master?

Not sure if everything is fixed but it worked with the Emu WPS.

@coveralls
Copy link

coveralls commented Nov 13, 2019

Coverage Status

Coverage remained the same at 75.132% when pulling f91bed6 on cehbrecht:issue-502-fix-async into f2704c8 on geopython:master.

@cehbrecht cehbrecht merged commit a0ff367 into geopython:master Nov 13, 2019
@cehbrecht cehbrecht deleted the issue-502-fix-async branch November 13, 2019 14:40
@cehbrecht
Copy link
Collaborator Author

@tomkralidis thanks for quick response :)

Copy link
Member

@jachym jachym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyWPS fails on python 3.7 due to async keyword

4 participants